[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #10114: fix: dashboard filter scope bug

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #10114:
URL: https://github.com/apache/incubator-superset/pull/10114#discussion_r443703305



##########
File path: superset-frontend/spec/javascripts/dashboard/util/getFilterScopeFromNodesTree_spec.js
##########
@@ -157,6 +159,107 @@ describe('getFilterScopeFromNodesTree', () => {
       },
     ];
 
+    // this is an other commonly used layout for dashboard:

Review comment:
       Dashboard filter's `scope` data is defined as 
   - `scopes`: contain one or more tabs(or root_id when dashboard has no tab). 
   - `immune` are charts under tab but immune from filter.
   If we only hold a list of `chartsInScope` will lost tab's scope information.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org