[GitHub] [spark] mengxr commented on a change in pull request #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext

[GitBox <gi...@apache.org>]

mengxr commented on a change in pull request #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext
URL: https://github.com/apache/spark/pull/27395#discussion_r378429562
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala
 ##########
 @@ -173,7 +207,18 @@ private[spark] class BarrierCoordinator(
         requesters: ArrayBuffer[RpcCallContext],
         numTasks: Int): Boolean = {
       if (requesters.size == numTasks) {
-        requesters.foreach(_.reply(()))
+        if (requestMethodToSync == RequestMethod.BARRIER) {
+          requesters.foreach(_.reply(""))
+        }
+        else if (requestMethodToSync == RequestMethod.ALL_GATHER) {
+          val jsonArray = JArray(
 
 Review comment:
   This is not needed. You can 'compact(render(allGatherMessages))' directly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org