You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/27 08:54:57 UTC

[GitHub] [hudi] wangxianghu opened a new pull request #4918: [WIP][HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

wangxianghu opened a new pull request #4918:
URL: https://github.com/apache/hudi/pull/4918


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   Currently, HoodieDeltaStreamer has supportted HiveSchemaProvider, but according to my test, it does not support hive table that using glue manage metadata.
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1070376118


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974",
       "triggerID" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6991",
       "triggerID" : "1068770601",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7022",
       "triggerID" : "1070375564",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 4be9c06e21020e9419112cc5402f3b2455c90c73 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6991) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7022) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4918: [WIP][HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1053388651


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b8e133958914003ec44cc3e7275fc6682b4edd32 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068770674


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974",
       "triggerID" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6991",
       "triggerID" : "1068770601",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 4be9c06e21020e9419112cc5402f3b2455c90c73 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6991) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1053454483


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b8e133958914003ec44cc3e7275fc6682b4edd32 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] wangxianghu commented on a change in pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#discussion_r818386566



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/HiveSchemaProvider.java
##########
@@ -52,12 +52,11 @@
   private final Schema sourceSchema;
   private Schema targetSchema;
 
-  public HiveSchemaProvider(TypedProperties props, JavaSparkContext jssc) {
-    super(props, jssc);
+  public HiveSchemaProvider(TypedProperties props, SparkSession spark) {
+    super(props, JavaSparkContext.fromSparkContext(spark.sparkContext()));
     DataSourceUtils.checkRequiredProperties(props, Collections.singletonList(Config.SOURCE_SCHEMA_TABLE_PROP));
     String sourceSchemaDatabaseName = props.getString(Config.SOURCE_SCHEMA_DATABASE_PROP, "default");
     String sourceSchemaTableName = props.getString(Config.SOURCE_SCHEMA_TABLE_PROP);
-    SparkSession spark = SparkSession.builder().config(jssc.getConf()).enableHiveSupport().getOrCreate();

Review comment:
       > does this create a new sparkSession rather than fetching an existing one and hence we had to do all the refactoring with JSSC and spark session is it ?
   
   It created a new one, with this sparkSession created inside HiveSchemaProvider i can not obtain glue data.
   I guess we need to refactor the jssc and sparksession, a big move.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068259045


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b8e133958914003ec44cc3e7275fc6682b4edd32 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360) 
   * cc266c26f5a96756ce36afe9a0fb7804c29adcce UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068806989


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974",
       "triggerID" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6991",
       "triggerID" : "1068770601",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 4be9c06e21020e9419112cc5402f3b2455c90c73 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6991) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] wangxianghu commented on a change in pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on a change in pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#discussion_r827262443



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -137,9 +138,9 @@ public HoodieDeltaStreamer(Config cfg, JavaSparkContext jssc, FileSystem fs, Con
 
     this.cfg = cfg;
     this.bootstrapExecutor = Option.ofNullable(

Review comment:
       > Can we instantiate JavaSparkContext as local variable and use it in lines 141 and 143.
   
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] wangxianghu commented on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068286192


   > @wangxianghu : can you rebase with latest master. we can land it in a day or two. patch looks good.
   Done
   sorry for the delay :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan commented on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1060034360


   @rmahindra123 : some refactoring around schema provider. Can you review it when you get a chance. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068330326


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974",
       "triggerID" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cc266c26f5a96756ce36afe9a0fb7804c29adcce Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970) 
   * 4be9c06e21020e9419112cc5402f3b2455c90c73 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068420799


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974",
       "triggerID" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4be9c06e21020e9419112cc5402f3b2455c90c73 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1070502805


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974",
       "triggerID" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6991",
       "triggerID" : "1068770601",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7022",
       "triggerID" : "1070375564",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 4be9c06e21020e9419112cc5402f3b2455c90c73 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6991) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7022) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068265292


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cc266c26f5a96756ce36afe9a0fb7804c29adcce Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4918: [WIP][HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1053391691


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b8e133958914003ec44cc3e7275fc6682b4edd32 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan commented on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1067496254


   @wangxianghu : can you rebase with latest master. we can land it in a day or two. patch looks good. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068262287


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b8e133958914003ec44cc3e7275fc6682b4edd32 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360) 
   * cc266c26f5a96756ce36afe9a0fb7804c29adcce Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068282673


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cc266c26f5a96756ce36afe9a0fb7804c29adcce Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970) 
   * 4be9c06e21020e9419112cc5402f3b2455c90c73 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068262287


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b8e133958914003ec44cc3e7275fc6682b4edd32 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360) 
   * cc266c26f5a96756ce36afe9a0fb7804c29adcce Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068282673


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cc266c26f5a96756ce36afe9a0fb7804c29adcce Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970) 
   * 4be9c06e21020e9419112cc5402f3b2455c90c73 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068806989


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974",
       "triggerID" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6991",
       "triggerID" : "1068770601",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 4be9c06e21020e9419112cc5402f3b2455c90c73 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6991) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068420799


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974",
       "triggerID" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4be9c06e21020e9419112cc5402f3b2455c90c73 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] wangxianghu commented on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1070375564


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan commented on a change in pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#discussion_r818126472



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -137,9 +138,9 @@ public HoodieDeltaStreamer(Config cfg, JavaSparkContext jssc, FileSystem fs, Con
 
     this.cfg = cfg;
     this.bootstrapExecutor = Option.ofNullable(

Review comment:
       Can we instantiate JavaSparkContext as local variable and use it in lines 141 and 143. 

##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/HiveSchemaProvider.java
##########
@@ -52,12 +52,11 @@
   private final Schema sourceSchema;
   private Schema targetSchema;
 
-  public HiveSchemaProvider(TypedProperties props, JavaSparkContext jssc) {
-    super(props, jssc);
+  public HiveSchemaProvider(TypedProperties props, SparkSession spark) {
+    super(props, JavaSparkContext.fromSparkContext(spark.sparkContext()));
     DataSourceUtils.checkRequiredProperties(props, Collections.singletonList(Config.SOURCE_SCHEMA_TABLE_PROP));
     String sourceSchemaDatabaseName = props.getString(Config.SOURCE_SCHEMA_DATABASE_PROP, "default");
     String sourceSchemaTableName = props.getString(Config.SOURCE_SCHEMA_TABLE_PROP);
-    SparkSession spark = SparkSession.builder().config(jssc.getConf()).enableHiveSupport().getOrCreate();

Review comment:
       does this create a new sparkSession rather than fetching an existing one and hence we had to do all the refactoring with JSSC and spark session is it ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1053454483


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b8e133958914003ec44cc3e7275fc6682b4edd32 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068330326


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974",
       "triggerID" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cc266c26f5a96756ce36afe9a0fb7804c29adcce Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970) 
   * 4be9c06e21020e9419112cc5402f3b2455c90c73 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1053391691


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b8e133958914003ec44cc3e7275fc6682b4edd32 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] wangxianghu commented on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1053540283


   hi @nsivabalan  do you have time to review this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4918: [WIP][HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1053388651


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b8e133958914003ec44cc3e7275fc6682b4edd32 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068259045


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b8e133958914003ec44cc3e7275fc6682b4edd32 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360) 
   * cc266c26f5a96756ce36afe9a0fb7804c29adcce UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068265292


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cc266c26f5a96756ce36afe9a0fb7804c29adcce Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1070376118


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974",
       "triggerID" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6991",
       "triggerID" : "1068770601",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7022",
       "triggerID" : "1070375564",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 4be9c06e21020e9419112cc5402f3b2455c90c73 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6991) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7022) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] wangxianghu commented on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068770601


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4918: [HUDI-3518] Make HiveSchemaProvider support AWS Glue Catalog

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4918:
URL: https://github.com/apache/hudi/pull/4918#issuecomment-1068770674


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6360",
       "triggerID" : "b8e133958914003ec44cc3e7275fc6682b4edd32",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6970",
       "triggerID" : "cc266c26f5a96756ce36afe9a0fb7804c29adcce",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974",
       "triggerID" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4be9c06e21020e9419112cc5402f3b2455c90c73",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6991",
       "triggerID" : "1068770601",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 4be9c06e21020e9419112cc5402f3b2455c90c73 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6974) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6991) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org