[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35075: [SPARK-37794][BUILD] Remove internal log4j bridge api usage

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #35075:
URL: https://github.com/apache/spark/pull/35075#discussion_r776925738



##########
File path: core/src/main/scala/org/apache/spark/internal/Logging.scala
##########
@@ -237,6 +231,19 @@ private[spark] object Logging {
     "org.apache.logging.slf4j.Log4jLoggerFactory".equals(binderClass)
   }
 
+  /**
+   * Return true if log4j2 is initialized by default configuration which has one
+   * appender with error level. See `org.apache.logging.log4j.core.config.DefaultConfiguration`.
+   */
+  private[spark] def islog4j2DefaultConfigured(): Boolean = {
+    val rootLogger = LogManager.getRootLogger.asInstanceOf[org.apache.logging.log4j.core.Logger]

Review comment:
       Can we use `import org.apache.logging.log4j.core.Logger` explicitly?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org