You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/12/03 03:44:54 UTC

[GitHub] [incubator-livy] huianyi commented on issue #238: [LIVY-689] Deliver stage process message to the end user using thriftserver

huianyi commented on issue #238: [LIVY-689] Deliver stage process message to the end user using thriftserver
URL: https://github.com/apache/incubator-livy/pull/238#issuecomment-560985424
 
 
   @mgaido91 The previous link you pointed actually is another feature we can implement(process bar), you can check it here, [HiveStatement.java#L381](https://github.com/apache/hive/blob/209096a71b25a3d75dca1930f825c8c10b99d2b9/jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java#L381) , [BeelineInPlaceUpdateStream.java#L39](https://github.com/apache/hive/blob/209096a71b25a3d75dca1930f825c8c10b99d2b9/beeline/src/java/org/apache/hive/beeline/logs/BeelineInPlaceUpdateStream.java#L39)
   
   Like I previous said, I can support this in a new PR.
   
   > > > Beeline from Hive 2.2 has in-place progress bar hive.server2.in.place.progress
   > > > https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-hive.server2.in.place.progress
   > > > (I think it works only with tez - would be nice if this would work with Livy too )
   > > 
   > > 
   > > Would be better to support this if it is not a big effort.
   > 
   > After reading hive related code, this needs write some new classes to implement this feature, which might cause this PR large, if you don not mind, I'd love to open a new PR to support this.
   
   ProcessBar is great in real-time interaction environment, but it can not work well if we do off-line scheduling jobs, we should print the job's status by individual lines in this circumstances.
   
   > In this way, we need to store nothing on Livy server memory.
   
   By default setting, we can keep each session keep not more than 100 rows, actually under normal circumstances, client will get these message immediately, this might not put much memory pressure on Livy server side. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services