You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/04/29 22:50:55 UTC
Re: Review Request 33646: [Proposal] Follow Google Style Guide for
include order completely.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33646/
-----------------------------------------------------------
(Updated April 29, 2015, 8:50 p.m.)
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Repository: mesos
Description
-------
Proposal for following Google Style Guide for include order completely.
Diffs
-----
docs/proposals/style/include_order.md PRE-CREATION
Diff: https://reviews.apache.org/r/33646/diff/
Testing
-------
Thanks,
Joerg Schad
Re: Review Request 33646: [Proposal] Follow Google Style Guide for
include order completely.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33646/#review82033
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33646]
All tests passed.
- Mesos ReviewBot
On April 29, 2015, 8:50 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33646/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 8:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Proposal for following Google Style Guide for include order completely.
>
>
> Diffs
> -----
>
> docs/proposals/style/include_order.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33646/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 33646: [Proposal] Follow Google Style Guide for
include order completely.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33646/#review82177
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On April 30, 2015, 7:17 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33646/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 7:17 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Bugs: MESOS-2673
> https://issues.apache.org/jira/browse/MESOS-2673
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Proposal for following Google Style Guide for include order completely.
>
>
> Diffs
> -----
>
> docs/proposals/style/include_order.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33646/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 33646: [Proposal] Follow Google Style Guide for
include order completely.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33646/#review88282
-----------------------------------------------------------
Is this a new folder? We usually have this kind of proposals and discussions in JIRA - wouldn't that be the place to get consensus and then go directly to the style guide?
- Niklas Nielsen
On April 30, 2015, 10:17 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33646/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 10:17 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
>
>
> Bugs: MESOS-2673
> https://issues.apache.org/jira/browse/MESOS-2673
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Proposal for following Google Style Guide for include order completely.
>
>
> Diffs
> -----
>
> docs/proposals/style/include_order.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33646/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 33646: [Proposal] Follow Google Style Guide for
include order completely.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33646/
-----------------------------------------------------------
(Updated April 30, 2015, 5:17 p.m.)
Review request for mesos, Benjamin Hindman and Joris Van Remoortere.
Bugs: MESOS-2673
https://issues.apache.org/jira/browse/MESOS-2673
Repository: mesos
Description
-------
Proposal for following Google Style Guide for include order completely.
Diffs
-----
docs/proposals/style/include_order.md PRE-CREATION
Diff: https://reviews.apache.org/r/33646/diff/
Testing
-------
Thanks,
Joerg Schad