You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/11/26 14:58:38 UTC
[GitHub] [ignite] ivandasch commented on a change in pull request #8483: IGNITE-13496 Java thin: make async API non-blocking with GridNioServer
ivandasch commented on a change in pull request #8483:
URL: https://github.com/apache/ignite/pull/8483#discussion_r531084116
##########
File path: modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/thin/JmhThinClientCacheBenchmark.java
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.benchmarks.jmh.thin;
+
+import java.util.concurrent.ThreadLocalRandom;
+
+import org.apache.ignite.internal.benchmarks.jmh.runner.JmhIdeBenchmarkRunner;
+import org.openjdk.jmh.annotations.Benchmark;
+
+/**
+ * Thin client cache benchmark.
+ *
+ * Benchmark Mode Cnt Score Error Units
+ * JmhThinClientCacheBenchmark.get thrpt 10 92501.557 ± 1380.384 ops/s
+ * JmhThinClientCacheBenchmark.put thrpt 10 82907.446 ± 7572.537 ops/s
Review comment:
+1
Also, it will be greate if we measure also latency (org.openjdk.jmh.annotations.Mode#AverageTime), not only trouhgput
##########
File path: modules/benchmarks/src/main/java/org/apache/ignite/internal/benchmarks/jmh/thin/JmhThinClientCacheBenchmark.java
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.benchmarks.jmh.thin;
+
+import java.util.concurrent.ThreadLocalRandom;
+
+import org.apache.ignite.internal.benchmarks.jmh.runner.JmhIdeBenchmarkRunner;
+import org.openjdk.jmh.annotations.Benchmark;
+
+/**
+ * Thin client cache benchmark.
+ *
+ * Benchmark Mode Cnt Score Error Units
+ * JmhThinClientCacheBenchmark.get thrpt 10 92501.557 ± 1380.384 ops/s
+ * JmhThinClientCacheBenchmark.put thrpt 10 82907.446 ± 7572.537 ops/s
Review comment:
+1
Also, it will be great if we measure also latency (org.openjdk.jmh.annotations.Mode#AverageTime), not only trouhgput
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org