You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2024/02/08 19:03:29 UTC
[PR] SOLR-17066: Switch Http2SolrClient away from coreURLs [solr]
gerlowskija opened a new pull request, #2255:
URL: https://github.com/apache/solr/pull/2255
https://issues.apache.org/jira/browse/SOLR-17066
# Description
SOLR-17066 introduced a `withDefaultCollection` builder method that can be used in lieu of providing a core URL as a "base". (Core URLs are not ideal as they prevent clients from making core-agnostic requests.)
However, Solr's own client usage still needs modified to use this new builder method.
# Solution
This commit migrates Http2SolrClient away from core URLs and towards using `withDefaultCollection`. This (along with #2254) are the last vestiges of core URLs in Solr!
# Tests
Tests continue to pass. No additional tests as this is "just" a refactor.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17066: Switch Http2SolrClient away from coreURLs [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #2255:
URL: https://github.com/apache/solr/pull/2255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17066: Switch Http2SolrClient away from coreURLs [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #2255:
URL: https://github.com/apache/solr/pull/2255#discussion_r1483492801
##########
solr/core/src/java/org/apache/solr/cli/PostLogsTool.java:
##########
@@ -89,9 +90,16 @@ public void runImpl(CommandLine cli) throws Exception {
}
public void runCommand(String baseUrl, String root, String credentials) throws IOException {
+ if (URLUtil.isBaseUrl(baseUrl)) {
Review Comment:
this is interesting.. I wonder if "url" is a good name for this parameter? I like the check... --collection-url? -collection-url.. though we dont have any other commands with a - in the name.... at least we have the check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org