You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/12/20 16:32:44 UTC

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1111: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient

nsivabalan commented on a change in pull request #1111: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient
URL: https://github.com/apache/incubator-hudi/pull/1111#discussion_r360442770
 
 

 ##########
 File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java
 ##########
 @@ -509,13 +522,21 @@ private Partitioner getPartitioner(HoodieTable table, boolean isUpsert, Workload
 
   /**
    * Commit changes performed at the given commitTime marker.
+   *
+   * @param commitTime Commit Time handle
+   * @param writeStatuses RDD of WriteStatus to inspect errors and counts
+   * @return true if commit successfully
 
 Review comment:
   minor. {@code true} if commit is successful. {@code false} otherwise. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services