You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/11/04 02:54:01 UTC

[GitHub] [rocketmq-client-go] codecov-io commented on issue #286: fix(consumer): goroutine leak when shutdown

codecov-io commented on issue #286: fix(consumer): goroutine leak when shutdown
URL: https://github.com/apache/rocketmq-client-go/pull/286#issuecomment-549210797
 
 
   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/286?src=pr&el=h1) Report
   > Merging [#286](https://codecov.io/gh/apache/rocketmq-client-go/pull/286?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/3eb471016c0d60e03044e42ced8baf08a3271897?src=pr&el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `14.28%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/286/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/286?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           native     #286      +/-   ##
   ==========================================
   - Coverage    26.5%   26.45%   -0.06%     
   ==========================================
     Files          46       46              
     Lines        4980     5001      +21     
   ==========================================
   + Hits         1320     1323       +3     
   - Misses       3481     3501      +20     
   + Partials      179      177       -2
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/286?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/286/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `14.44% <14.28%> (-0.01%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/286?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/286?src=pr&el=footer). Last update [3eb4710...a4e7f33](https://codecov.io/gh/apache/rocketmq-client-go/pull/286?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services