You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/07 21:40:52 UTC
[GitHub] [airflow] ashb edited a comment on pull request #9174: Don't use the term "whitelist" - language matters
ashb edited a comment on pull request #9174:
URL: https://github.com/apache/airflow/pull/9174#issuecomment-640282560
There are a few references left over.
- In the Cassandra hook, because of the `WhiteListRoundRobinPolicy` class - https://issues.apache.org/jira/browse/CASSANDRA-15862
- In our default_webserver_config.py class https://github.com/dpgaspar/Flask-AppBuilder/issues/1390
- In our pylintrc file https://github.com/PyCQA/pylint/issues/3669
- In our UPDATING.md (for Airflow 1.8) when referencing a hive security setting. I don't even know if this is relevant anymore.
```
airflow/config_templates/default_webserver_config.py:# 'whitelist': ['@YOU_COMPANY_DOMAIN'], # optional
airflow/providers/apache/cassandra/hooks/cassandra.py: DCAwareRoundRobinPolicy, RoundRobinPolicy, TokenAwarePolicy, WhiteListRoundRobinPolicy,
airflow/providers/apache/cassandra/hooks/cassandra.py:Policy = Union[DCAwareRoundRobinPolicy, RoundRobinPolicy, TokenAwarePolicy, WhiteListRoundRobinPolicy]
airflow/providers/apache/cassandra/hooks/cassandra.py: - WhiteListRoundRobinPolicy
airflow/providers/apache/cassandra/hooks/cassandra.py: 'load_balancing_policy': 'WhiteListRoundRobinPolicy',
airflow/providers/apache/cassandra/hooks/cassandra.py: if policy_name == 'WhiteListRoundRobinPolicy':
airflow/providers/apache/cassandra/hooks/cassandra.py: raise Exception('Hosts must be specified for WhiteListRoundRobinPolicy')
airflow/providers/apache/cassandra/hooks/cassandra.py: return WhiteListRoundRobinPolicy(hosts)
airflow/providers/apache/cassandra/hooks/cassandra.py: 'WhiteListRoundRobinPolicy',)
airflow/providers/apache/hive/operators/hive_stats.py: if 'col_blacklist' in kwargs:
airflow/providers/apache/hive/operators/hive_stats.py: 'col_blacklist kwarg passed to {c} (task_id: {t}) is deprecated, please rename it to '
airflow/providers/apache/hive/operators/hive_stats.py: excluded_columns = kwargs.pop('col_blacklist')
pylintrc:extension-pkg-whitelist=setproctitle
tests/providers/apache/cassandra/hooks/test_cassandra.py: DCAwareRoundRobinPolicy, RoundRobinPolicy, TokenAwarePolicy, WhiteListRoundRobinPolicy,
tests/providers/apache/cassandra/hooks/test_cassandra.py: # test WhiteListRoundRobinPolicy with args
tests/providers/apache/cassandra/hooks/test_cassandra.py: self._assert_get_lb_policy('WhiteListRoundRobinPolicy',
tests/providers/apache/cassandra/hooks/test_cassandra.py: WhiteListRoundRobinPolicy)
tests/providers/apache/cassandra/hooks/test_cassandra.py: {'child_load_balancing_policy': 'WhiteListRoundRobinPolicy',
tests/providers/apache/cassandra/hooks/test_cassandra.py: }, TokenAwarePolicy, expected_child_policy_type=WhiteListRoundRobinPolicy)
tests/providers/apache/cassandra/hooks/test_cassandra.py: # test host not specified for WhiteListRoundRobinPolicy should throw exception
tests/providers/apache/cassandra/hooks/test_cassandra.py: self._assert_get_lb_policy('WhiteListRoundRobinPolicy',
tests/providers/apache/cassandra/hooks/test_cassandra.py: WhiteListRoundRobinPolicy,
tests/providers/apache/cassandra/hooks/test_cassandra.py: {'child_load_balancing_policy': 'WhiteListRoundRobinPolicy'},
```
It is probably worth adding a check for this: `git grep -Ei '(black|white)[_-]?list'` sort of thing, if we can easily exclude some files/occurrences.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org