You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/01/22 01:44:57 UTC

[PR] [SPARK-55126][PYTHON] Remove unused timezone and assign_cols_by_name from ArrowStreamArrowUDFSerializer [spark]

Yicong-Huang opened a new pull request, #53904:
URL: https://github.com/apache/spark/pull/53904

### What changes were proposed in this pull request?

This PR removes unused `timezone` and `assign_cols_by_name` parameters from `ArrowStreamArrowUDFSerializer` and related classes.

### Why are the changes needed?

As noted in the JIRA ticket, `ArrowStreamArrowUDFSerializer` stores `timezone` and `assign_cols_by_name` but never uses them. Arrow serializers operate directly on Arrow arrays without pandas conversion, so these parameters are unnecessary.

This cleanup:
1. Removes dead code and unnecessary parameters
2. Simplifies the serializer API
3. Reduces memory footprint by not storing unused instance variables

### Does this PR introduce _any_ user-facing change?

No. These are internal implementation details.

### How was this patch tested?

Existing unit tests should cover this change as the functionality remains the same.

### Was this patch authored or co-authored using generative AI tooling?

No.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-55126][PYTHON] Remove unused timezone and assign_cols_by_name from ArrowStreamArrowUDFSerializer [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.

zhengruifeng commented on PR #53904:
URL: https://github.com/apache/spark/pull/53904#issuecomment-3783158069

   merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-55126][PYTHON] Remove unused timezone and assign_cols_by_name from ArrowStreamArrowUDFSerializer [spark]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.

Yicong-Huang commented on PR #53904:
URL: https://github.com/apache/spark/pull/53904#issuecomment-3782397773

   > shall we add some comments around `runner_conf.assign_cols_by_name` about what eval types should `assign_cols_by_name` take effect?
   
   maybe I can do it in another PR? need to clean up those config's affecting scopes systematically. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-55126][PYTHON] Remove unused timezone and assign_cols_by_name from ArrowStreamArrowUDFSerializer [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.

zhengruifeng closed pull request #53904: [SPARK-55126][PYTHON] Remove unused timezone and assign_cols_by_name from ArrowStreamArrowUDFSerializer
URL: https://github.com/apache/spark/pull/53904


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-55126][PYTHON] Remove unused timezone and assign_cols_by_name from ArrowStreamArrowUDFSerializer [spark]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #53904:
URL: https://github.com/apache/spark/pull/53904#issuecomment-3782031492

   ## JIRA Issue Information
   
   === Improvement SPARK-55126 ===
   Summary: Remove unused timezone and assign_cols_by_name from ArrowStreamArrowUDFSerializer
   Assignee: None
   Status: Open
   Affected: ["4.2.0"]
   
   ---
   *This comment was automatically generated by GitHub Actions*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-55126][PYTHON] Remove unused timezone and assign_cols_by_name from ArrowStreamArrowUDFSerializer [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.

zhengruifeng commented on PR #53904:
URL: https://github.com/apache/spark/pull/53904#issuecomment-3782301697

   shall we add some comments around `runner_conf.assign_cols_by_name` about what eval types should `assign_cols_by_name` take effect?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org