You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/03/12 17:41:36 UTC
[GitHub] [commons-collections] aherbert commented on a change in pull
request #140: Bloomfilter updates2
aherbert commented on a change in pull request #140: Bloomfilter updates2
URL: https://github.com/apache/commons-collections/pull/140#discussion_r391786819
##########
File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/Shape.java
##########
@@ -43,30 +43,32 @@
* [Wikipedia]</a>
* @since 4.5
*/
-public class Shape {
+public final class Shape {
/**
- * The natural logarithm of 2. Used in several calculations. approx 0.693147180
+ * The natural logarithm of 2. Used in several calculations. Approximately 0.693147180559945.
*/
private static final double LOG_OF_2 = Math.log(2.0);
/**
- * 1 / 2^log(2) approx -0.090619058. Used in calculating the number of bits.
+ * log(1 / 2^log(2)). Used in calculating the number of bits. Approximately -0.480453013918201.
Review comment:
Are you saying that the value is now wrong or right? I make it -0.48. Or am I doing something wrong with my calculator?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services