You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/09/06 14:07:22 UTC
[GitHub] [hbase] infraio commented on a change in pull request #2010: HBASE-24391 Implement meta split
infraio commented on a change in pull request #2010:
URL: https://github.com/apache/hbase/pull/2010#discussion_r484074508
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncScanSingleRegionRpcRetryingCaller.java
##########
@@ -442,6 +449,32 @@ private void updateNextStartRowWhenError(Result result) {
includeNextStartRowWhenError = result.mayHaveMoreCellsInRow();
}
+ private boolean noMoreResultsForScan(Scan scan, RegionInfo info) {
+ if (isEmptyStopRow(info.getEndKey())) {
+ return true;
+ }
+ if (isEmptyStopRow(scan.getStopRow())) {
+ return false;
+ }
+ int c = comparator.compare(info.getEndKey(), scan.getStopRow());
Review comment:
Why don't need comparator previously? Don't use this to scan meta previously?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org