[GitHub] [airflow] potiuk commented on a change in pull request #20214: Fixing MyPy issues in www fab_security manager

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #20214:
URL: https://github.com/apache/airflow/pull/20214#discussion_r767266497



##########
File path: airflow/www/fab_security/manager.py
##########
@@ -104,12 +106,18 @@ class BaseSecurityManager:
     """ Flask-OpenID OpenID """
     oauth = None
     """ Flask-OAuth """
-    oauth_remotes = None
+    oauth_remotes: Dict[str, Any]
     """ OAuth email whitelists """
-    oauth_whitelists = {}
+    oauth_whitelists: Dict[str, List]
     """ Initialized (remote_app) providers dict {'provider_name', OBJ } """
-    oauth_tokengetter = _oauth_tokengetter
-    """ OAuth tokengetter function override to implement your own tokengetter method """
+
+    @staticmethod
+    def oauth_tokengetter():
+        """Authentication (OAuth) token getter function.
+        Override to implement your own token getter method
+        """
+        return _oauth_tokengetter

Review comment:
       Fine for me. I like it more too @uranusjr ? Does it work for you ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org