You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by jd...@apache.org on 2022/01/30 17:56:44 UTC

[qpid-dispatch] branch jd_tryout updated (c588029 -> 2420bb3)

This is an automated email from the ASF dual-hosted git repository.

jdanek pushed a change to branch jd_tryout
in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git.


    from c588029  fixup typing DISPATCH-2323 Add Pytest-compatible logging displayed on test failure
     new 2027026  fixup caputure pytest DISPATCH-2323 Add Pytest-compatible logging displayed on test failure
     new 2420bb3  fixup freeing closing server DISPATCH-2323 Add Pytest-compatible logging displayed on test failure

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 tests/system_tests_http1_adaptor.py | 16 +++++++++-------
 tests/tox.ini.in                    |  3 +++
 2 files changed, 12 insertions(+), 7 deletions(-)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


[qpid-dispatch] 01/02: fixup caputure pytest DISPATCH-2323 Add Pytest-compatible logging displayed on test failure

Posted by jd...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

jdanek pushed a commit to branch jd_tryout
in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git

commit 2027026e820e2fbf6a271345c8deaa08a16b5b70
Author: Jiri Daněk <jd...@redhat.com>
AuthorDate: Sun Jan 30 18:55:50 2022 +0100

    fixup caputure pytest DISPATCH-2323 Add Pytest-compatible logging displayed on test failure
---
 tests/tox.ini.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/tox.ini.in b/tests/tox.ini.in
index 7f9c91c..96786c2 100644
--- a/tests/tox.ini.in
+++ b/tests/tox.ini.in
@@ -149,6 +149,9 @@ exclude =
 # do not filter test file names
 python_files = *.py
 
+# https://docs.pytest.org/en/6.2.x/logging.html#incompatible-changes-in-pytest-3-4
+log_level = DEBUG
+
 # pylint
 [MESSAGE_CONTROL]
 disable =

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


[qpid-dispatch] 02/02: fixup freeing closing server DISPATCH-2323 Add Pytest-compatible logging displayed on test failure

Posted by jd...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

jdanek pushed a commit to branch jd_tryout
in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git

commit 2420bb3cd266207e427e8829da7fea1da360ce40
Author: Jiri Daněk <jd...@redhat.com>
AuthorDate: Sun Jan 30 18:56:36 2022 +0100

    fixup freeing closing server DISPATCH-2323 Add Pytest-compatible logging displayed on test failure
---
 tests/system_tests_http1_adaptor.py | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/tests/system_tests_http1_adaptor.py b/tests/system_tests_http1_adaptor.py
index 3800012..82c2382 100644
--- a/tests/system_tests_http1_adaptor.py
+++ b/tests/system_tests_http1_adaptor.py
@@ -208,13 +208,15 @@ class Http1AdaptorManagementTest(TestCase):
         self.assertEqual(1, len(e_mgmt.query(type=self.CONNECTOR_TYPE).results))
 
         server = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
-        server.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
-        server.bind(("", self.http_server_port))
-        server.setblocking(True)
-        server.settimeout(5)
-        server.listen(1)
-        conn, _ = server.accept()
-        server.close()
+        try:
+            server.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
+            server.bind(("", self.http_server_port))
+            server.setblocking(True)
+            server.settimeout(5)
+            server.listen(1)
+            conn, _ = server.accept()
+        finally:
+            server.close()
 
         # now check the interior router for the closest/http1Service address
         self.i_router.wait_address("closest/http1Service", subscribers=1)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org