You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/02 02:48:03 UTC

[GitHub] [spark] cloud-fan commented on pull request #35701: [SPARK-38378][SQL] Refactoring of the ANTLR grammar definition into separate Parser and Lexer files

cloud-fan commented on pull request #35701:
URL: https://github.com/apache/spark/pull/35701#issuecomment-1056088643


   Is this a best practice of ANTLR? It does look cleaner to separate lexer and parser rules.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org