[jira] [Created] (SLING-11055) Cleanup Repoinit Parser Code Smells

["Dan Klco (Jira)" <ji...@apache.org>]

Dan Klco created SLING-11055:
--------------------------------

             Summary: Cleanup Repoinit Parser Code Smells
                 Key: SLING-11055
                 URL: https://issues.apache.org/jira/browse/SLING-11055
             Project: Sling
          Issue Type: Improvement
          Components: Repoinit
    Affects Versions: Repoinit Parser 1.6.10
            Reporter: Dan Klco
            Assignee: Dan Klco
             Fix For: Repoinit Parser 1.6.12


There are 31 open code smells identified by SonarQube for the RepoInit Parser:
https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&resolved=false&types=CODE_SMELL

Most are trivial to fix and don't impact the public surface, such as:

 * removing unneeded semi-colons
 * not specifying second generic parameters
 * ensuring assertions are present in all tests
 * including the override annotations

There are a few that would either be more difficult to resolve or may change the public surface and therefore aren't going to be addressed in this ticket, specifically:

 * code duplication
 * avoiding built in exception types
 * enum naming



--
This message was sent by Atlassian Jira
(v8.20.1#820001)