You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@gmail.com> on 2018/06/22 07:32:17 UTC
Review Request 67697: RANGER-2140: Upgrade spring and guava libraries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67697/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul Parikh, suja s, and Velmurugan Periasamy.
Bugs: RANGER-2140
https://issues.apache.org/jira/browse/RANGER-2140
Repository: ranger
Description
-------
Here I am proposing to change Guava version to 25.1, currently there are three different version are being used. Also proposing to change Spring Security to 4.2.7 and Spring Framework to 4.3.18.
Diffs
-----
kms/pom.xml 9ca9270
plugin-atlas/pom.xml a1f0c37
pom.xml 0795210
src/main/assembly/kms.xml 7fbc141
src/main/assembly/plugin-atlas.xml 8f4a64c
src/main/assembly/plugin-kms.xml 6d15f2a
src/main/assembly/plugin-solr.xml de30bfb
ugsync/pom.xml c636f9f
unixauthclient/pom.xml f859fff
unixauthservice/pom.xml c4fe07d
Diff: https://reviews.apache.org/r/67697/diff/1/
Testing
-------
Tested Ranger admin installation, user login, usersync and other crud operations on service, policy, user and group module.
Thanks,
Pradeep Agrawal
Re: Review Request 67697: RANGER-2140: Upgrade spring and guava
libraries
Posted by Pradeep Agrawal <pr...@gmail.com>.
> On June 22, 2018, 6:51 p.m., Velmurugan Periasamy wrote:
> >
reverted the changes of Guava library and test cases are passing now.
we can't use the latest guava library as few third party libraries are still dependent on older version of guava library.
- Pradeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67697/#review205245
-----------------------------------------------------------
On June 25, 2018, 10:26 a.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67697/
> -----------------------------------------------------------
>
> (Updated June 25, 2018, 10:26 a.m.)
>
>
> Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul Parikh, suja s, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2140
> https://issues.apache.org/jira/browse/RANGER-2140
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Here I am proposing to change Guava version to only 17.0, currently there are three different version are being used. Also proposing to change Spring Security to 4.2.7 and Spring Framework to 4.3.18.
>
>
> Diffs
> -----
>
> kms/pom.xml 9ca9270
> plugin-atlas/pom.xml a1f0c37
> pom.xml 0795210
> src/main/assembly/kms.xml 7fbc141
> src/main/assembly/plugin-atlas.xml 8f4a64c
> src/main/assembly/plugin-kms.xml 6d15f2a
> src/main/assembly/plugin-solr.xml de30bfb
> ugsync/pom.xml c636f9f
> unixauthclient/pom.xml f859fff
> unixauthservice/pom.xml c4fe07d
>
>
> Diff: https://reviews.apache.org/r/67697/diff/2/
>
>
> Testing
> -------
>
> Tested Ranger admin installation, user login, usersync and other crud operations on service, policy, user and group module.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>
Re: Review Request 67697: RANGER-2140: Upgrade spring and guava
libraries
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67697/#review205245
-----------------------------------------------------------
pom.xml
Line 159 (original), 158 (patched)
<https://reviews.apache.org/r/67697/#comment288178>
I get test failures with this patch. Please check and fix them.
```
-------------------------------------------------------------------------------
Test set: org.apache.ranger.services.knox.KnoxRangerTest
-------------------------------------------------------------------------------
Tests run: 10, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 16.777 s <<< FAILURE! - in org.apache.ranger.services.knox.KnoxRangerTest
testHDFSAllowed(org.apache.ranger.services.knox.KnoxRangerTest) Time elapsed: 1.8 s <<< FAILURE!
java.lang.AssertionError:
1 expectation failed.
Expected status code <200> but was <500>.
at org.apache.ranger.services.knox.KnoxRangerTest.makeWebHDFSInvocation(KnoxRangerTest.java:207)
at org.apache.ranger.services.knox.KnoxRangerTest.testHDFSAllowed(KnoxRangerTest.java:133)
testSolrAllowed(org.apache.ranger.services.knox.KnoxRangerTest) Time elapsed: 0.031 s <<< FAILURE!
java.lang.AssertionError:
1 expectation failed.
Expected status code <200> but was <403>.
at org.apache.ranger.services.knox.KnoxRangerTest.makeSolrInvocation(KnoxRangerTest.java:317)
at org.apache.ranger.services.knox.KnoxRangerTest.testSolrAllowed(KnoxRangerTest.java:173)
testKafkaAllowed(org.apache.ranger.services.knox.KnoxRangerTest) Time elapsed: 0.024 s <<< FAILURE!
java.lang.AssertionError:
1 expectation failed.
Expected status code <200> but was <403>.
at org.apache.ranger.services.knox.KnoxRangerTest.makeKafkaInvocation(KnoxRangerTest.java:287)
at org.apache.ranger.services.knox.KnoxRangerTest.testKafkaAllowed(KnoxRangerTest.java:163)
testStormUiAllowed(org.apache.ranger.services.knox.KnoxRangerTest) Time elapsed: 0.022 s <<< FAILURE!
java.lang.AssertionError:
1 expectation failed.
Expected status code <200> but was <403>.
at org.apache.ranger.services.knox.KnoxRangerTest.makeStormUIInvocation(KnoxRangerTest.java:238)
at org.apache.ranger.services.knox.KnoxRangerTest.testStormUiAllowed(KnoxRangerTest.java:143)
testHBaseAllowed(org.apache.ranger.services.knox.KnoxRangerTest) Time elapsed: 0.017 s <<< FAILURE!
java.lang.AssertionError:
1 expectation failed.
Expected status code <200> but was <403>.
at org.apache.ranger.services.knox.KnoxRangerTest.makeHBaseInvocation(KnoxRangerTest.java:267)
at org.apache.ranger.services.knox.KnoxRangerTest.testHBaseAllowed(KnoxRangerTest.java:153)
```
- Velmurugan Periasamy
On June 22, 2018, 7:32 a.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67697/
> -----------------------------------------------------------
>
> (Updated June 22, 2018, 7:32 a.m.)
>
>
> Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul Parikh, suja s, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2140
> https://issues.apache.org/jira/browse/RANGER-2140
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Here I am proposing to change Guava version to 25.1, currently there are three different version are being used. Also proposing to change Spring Security to 4.2.7 and Spring Framework to 4.3.18.
>
>
> Diffs
> -----
>
> kms/pom.xml 9ca9270
> plugin-atlas/pom.xml a1f0c37
> pom.xml 0795210
> src/main/assembly/kms.xml 7fbc141
> src/main/assembly/plugin-atlas.xml 8f4a64c
> src/main/assembly/plugin-kms.xml 6d15f2a
> src/main/assembly/plugin-solr.xml de30bfb
> ugsync/pom.xml c636f9f
> unixauthclient/pom.xml f859fff
> unixauthservice/pom.xml c4fe07d
>
>
> Diff: https://reviews.apache.org/r/67697/diff/1/
>
>
> Testing
> -------
>
> Tested Ranger admin installation, user login, usersync and other crud operations on service, policy, user and group module.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>
Re: Review Request 67697: RANGER-2140: Upgrade spring and guava
libraries
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67697/#review209327
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Oct. 8, 2018, 7:28 a.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67697/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2018, 7:28 a.m.)
>
>
> Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul Parikh, suja s, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2140
> https://issues.apache.org/jira/browse/RANGER-2140
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Here I am proposing to change Guava version to only 17.0, currently there are three different version are being used. Also proposing to change Spring Security to 4.2.7 and Spring Framework to 4.3.18.
>
>
> Diffs
> -----
>
> kms/pom.xml 6fc190f35
> knox-agent/src/test/resources/log4j.properties 2c9f1b2f1
> plugin-atlas/pom.xml fcc037f93
> pom.xml 1fd660c1a
> src/main/assembly/kms.xml 7fbc1410c
> src/main/assembly/plugin-atlas.xml 8f4a64cb6
> src/main/assembly/plugin-kms.xml 6d15f2a10
> src/main/assembly/plugin-solr.xml de30bfb13
> ugsync/pom.xml f4c24e739
> unixauthclient/pom.xml cd3d15604
> unixauthservice/pom.xml 2c0ed2eef
>
>
> Diff: https://reviews.apache.org/r/67697/diff/4/
>
>
> Testing
> -------
>
> Tested Ranger admin installation, user login, usersync and other crud operations on service, policy, user and group module.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>
Re: Review Request 67697: RANGER-2140: Upgrade spring and guava
libraries
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67697/
-----------------------------------------------------------
(Updated Oct. 8, 2018, 7:28 a.m.)
Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul Parikh, suja s, and Velmurugan Periasamy.
Changes
-------
Updated review request
Bugs: RANGER-2140
https://issues.apache.org/jira/browse/RANGER-2140
Repository: ranger
Description
-------
Here I am proposing to change Guava version to only 17.0, currently there are three different version are being used. Also proposing to change Spring Security to 4.2.7 and Spring Framework to 4.3.18.
Diffs (updated)
-----
kms/pom.xml 6fc190f35
knox-agent/src/test/resources/log4j.properties 2c9f1b2f1
plugin-atlas/pom.xml fcc037f93
pom.xml 1fd660c1a
src/main/assembly/kms.xml 7fbc1410c
src/main/assembly/plugin-atlas.xml 8f4a64cb6
src/main/assembly/plugin-kms.xml 6d15f2a10
src/main/assembly/plugin-solr.xml de30bfb13
ugsync/pom.xml f4c24e739
unixauthclient/pom.xml cd3d15604
unixauthservice/pom.xml 2c0ed2eef
Diff: https://reviews.apache.org/r/67697/diff/4/
Changes: https://reviews.apache.org/r/67697/diff/3-4/
Testing
-------
Tested Ranger admin installation, user login, usersync and other crud operations on service, policy, user and group module.
Thanks,
Pradeep Agrawal
Re: Review Request 67697: RANGER-2140: Upgrade spring and guava
libraries
Posted by Colm O hEigeartaigh <co...@apache.org>.
> On Oct. 2, 2018, 9:06 p.m., Velmurugan Periasamy wrote:
> > knox-agent/src/test/java/org/apache/ranger/services/knox/KnoxRangerTest.java
> > Lines 46 (patched)
> > <https://reviews.apache.org/r/67697/diff/3/?file=2092586#file2092586line46>
> >
> > Upgrading to 25.1-jre is a good idea.
> >
> > Instead of ignoring the test, my suggestion is to fix the issue.
> >
> > Also if this JIRA is going to be used only for Guava upgrade, please update the description in RR and JIRA. For spring version upgrade, please create a new JIRA. Thanks.
+1 to fixiing the issue. Weirdly, just uncommenting "ranger.root.logger=WARN,console" in src/test/resources/log4j.properties makes the tests pass, so I guess thre is some sort of timing issue.
- Colm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67697/#review209162
-----------------------------------------------------------
On June 25, 2018, 10:26 a.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67697/
> -----------------------------------------------------------
>
> (Updated June 25, 2018, 10:26 a.m.)
>
>
> Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul Parikh, suja s, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2140
> https://issues.apache.org/jira/browse/RANGER-2140
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Here I am proposing to change Guava version to only 17.0, currently there are three different version are being used. Also proposing to change Spring Security to 4.2.7 and Spring Framework to 4.3.18.
>
>
> Diffs
> -----
>
> kms/pom.xml 6fc190f35
> knox-agent/src/test/java/org/apache/ranger/services/knox/KnoxRangerTest.java 764192172
> plugin-atlas/pom.xml fcc037f93
> pom.xml e6695b440
> src/main/assembly/kms.xml 7fbc1410c
> src/main/assembly/plugin-atlas.xml 8f4a64cb6
> src/main/assembly/plugin-kms.xml 6d15f2a10
> src/main/assembly/plugin-solr.xml de30bfb13
> ugsync/pom.xml f4c24e739
> unixauthclient/pom.xml cd3d15604
> unixauthservice/pom.xml 2c0ed2eef
>
>
> Diff: https://reviews.apache.org/r/67697/diff/3/
>
>
> Testing
> -------
>
> Tested Ranger admin installation, user login, usersync and other crud operations on service, policy, user and group module.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>
Re: Review Request 67697: RANGER-2140: Upgrade spring and guava
libraries
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67697/#review209162
-----------------------------------------------------------
knox-agent/src/test/java/org/apache/ranger/services/knox/KnoxRangerTest.java
Lines 46 (patched)
<https://reviews.apache.org/r/67697/#comment293453>
Upgrading to 25.1-jre is a good idea.
Instead of ignoring the test, my suggestion is to fix the issue.
Also if this JIRA is going to be used only for Guava upgrade, please update the description in RR and JIRA. For spring version upgrade, please create a new JIRA. Thanks.
- Velmurugan Periasamy
On June 25, 2018, 10:26 a.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67697/
> -----------------------------------------------------------
>
> (Updated June 25, 2018, 10:26 a.m.)
>
>
> Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul Parikh, suja s, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2140
> https://issues.apache.org/jira/browse/RANGER-2140
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Here I am proposing to change Guava version to only 17.0, currently there are three different version are being used. Also proposing to change Spring Security to 4.2.7 and Spring Framework to 4.3.18.
>
>
> Diffs
> -----
>
> kms/pom.xml 6fc190f35
> knox-agent/src/test/java/org/apache/ranger/services/knox/KnoxRangerTest.java 764192172
> plugin-atlas/pom.xml fcc037f93
> pom.xml e6695b440
> src/main/assembly/kms.xml 7fbc1410c
> src/main/assembly/plugin-atlas.xml 8f4a64cb6
> src/main/assembly/plugin-kms.xml 6d15f2a10
> src/main/assembly/plugin-solr.xml de30bfb13
> ugsync/pom.xml f4c24e739
> unixauthclient/pom.xml cd3d15604
> unixauthservice/pom.xml 2c0ed2eef
>
>
> Diff: https://reviews.apache.org/r/67697/diff/3/
>
>
> Testing
> -------
>
> Tested Ranger admin installation, user login, usersync and other crud operations on service, policy, user and group module.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>
Re: Review Request 67697: RANGER-2140: Upgrade spring and guava
libraries
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67697/
-----------------------------------------------------------
(Updated June 25, 2018, 10:26 a.m.)
Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul Parikh, suja s, and Velmurugan Periasamy.
Changes
-------
roledback changes related to use of latest Guava lib as few third parties libraries are having dependency on older version of guava library.
Bugs: RANGER-2140
https://issues.apache.org/jira/browse/RANGER-2140
Repository: ranger
Description (updated)
-------
Here I am proposing to change Guava version to only 17.0, currently there are three different version are being used. Also proposing to change Spring Security to 4.2.7 and Spring Framework to 4.3.18.
Diffs (updated)
-----
kms/pom.xml 9ca9270
plugin-atlas/pom.xml a1f0c37
pom.xml 0795210
src/main/assembly/kms.xml 7fbc141
src/main/assembly/plugin-atlas.xml 8f4a64c
src/main/assembly/plugin-kms.xml 6d15f2a
src/main/assembly/plugin-solr.xml de30bfb
ugsync/pom.xml c636f9f
unixauthclient/pom.xml f859fff
unixauthservice/pom.xml c4fe07d
Diff: https://reviews.apache.org/r/67697/diff/2/
Changes: https://reviews.apache.org/r/67697/diff/1-2/
Testing
-------
Tested Ranger admin installation, user login, usersync and other crud operations on service, policy, user and group module.
Thanks,
Pradeep Agrawal