You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-commits@xmlgraphics.apache.org by ac...@apache.org on 2008/07/21 14:58:18 UTC
svn commit: r678405 -
/xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/DataObjectCache.java
Author: acumiskey
Date: Mon Jul 21 05:58:18 2008
New Revision: 678405
URL: http://svn.apache.org/viewvc?rev=678405&view=rev
Log:
Must synchronize on cacheMap when removing DataObjectCache instance.
Modified:
xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/DataObjectCache.java
Modified: xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/DataObjectCache.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/DataObjectCache.java?rev=678405&r1=678404&r2=678405&view=diff
==============================================================================
--- xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/DataObjectCache.java (original)
+++ xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/DataObjectCache.java Mon Jul 21 05:58:18 2008
@@ -25,6 +25,7 @@
import java.io.RandomAccessFile;
import java.nio.MappedByteBuffer;
import java.nio.channels.FileChannel;
+import java.util.Collections;
import java.util.Map;
import org.apache.commons.logging.Log;
@@ -48,6 +49,7 @@
private static Map/*<Integer,DataObjectCache>*/ cacheMap
= new java.util.HashMap/*<Integer,DataObjectCache>*/();
+
/** Mapping of data object uri --> cache record */
private Map/*<ResourceInfo,Record>*/ includableMap
= new java.util.HashMap/*<ResourceInfo,Record>*/();
@@ -110,7 +112,9 @@
try {
raFile.close();
tempFile.delete();
- cacheMap.remove(id); // remove ourselves from the cache map
+ synchronized (cacheMap) {
+ cacheMap.remove(id); // remove ourselves from the cache map
+ }
} catch (IOException e) {
log.error("Failed to close temporary file");
}
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org