You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/05/25 01:48:21 UTC

[GitHub] [incubator-iotdb] SailVR opened a new pull request #1256: delete serial num

SailVR opened a new pull request #1256:
URL: https://github.com/apache/incubator-iotdb/pull/1256


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-iotdb] qiaojialin merged pull request #1256: delete serial num

Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #1256:
URL: https://github.com/apache/incubator-iotdb/pull/1256


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-iotdb] qiaojialin commented on pull request #1256: delete serial num

Posted by GitBox <gi...@apache.org>.
qiaojialin commented on pull request #1256:
URL: https://github.com/apache/incubator-iotdb/pull/1256#issuecomment-633362099


   Hi, @HTHou @samperson1997 , the reason to remove the number is when I want to add one document between 1 and 2, I need to modify all the following documents' numbers, which is very disturbing. After removing the number, we just need to maintain the order in config.js.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-iotdb] HTHou commented on pull request #1256: delete serial num

Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #1256:
URL: https://github.com/apache/incubator-iotdb/pull/1256#issuecomment-633348820


   Can you please tell us why it's necessary to delete the numbers? It will help others to understand the meaning of this PR. Thanks. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-iotdb] samperson1997 edited a comment on pull request #1256: delete serial num

Posted by GitBox <gi...@apache.org>.
samperson1997 edited a comment on pull request #1256:
URL: https://github.com/apache/incubator-iotdb/pull/1256#issuecomment-633359479


   > Can you please tell us why it's necessary to delete the numbers? It will help others to understand the meaning of this PR. Thanks.
   
   Actually I think the numbers can be used to maintain the correct order of the documents in IDE ... (otherwise the documents are just in alphabet order > <). And it would be easy for developers to index the documents : (


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-iotdb] samperson1997 commented on pull request #1256: delete serial num

Posted by GitBox <gi...@apache.org>.
samperson1997 commented on pull request #1256:
URL: https://github.com/apache/incubator-iotdb/pull/1256#issuecomment-633359479


   > Can you please tell us why it's necessary to delete the numbers? It will help others to understand the meaning of this PR. Thanks.
   
   Actually I think the numbers can be used to maintain the correct order of the documents in IDE ... And it would be easy for developers to index the documents : (


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org