You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Chug Rolke <cr...@redhat.com> on 2012/11/06 20:20:57 UTC
Review Request: C++ Broker should not declare existing federated queues
during bridge creation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7901/
-----------------------------------------------------------
Review request for qpid and Alan Conway.
Description
-------
This patch conditionalizes the queue declaration during bridge creation. The queue is declared only if there is no existing queue, which is when the supplied queue name is blank.
This addresses bug QPID-4423.
https://issues.apache.org/jira/browse/QPID-4423
Diffs
-----
trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1406267
Diff: https://reviews.apache.org/r/7901/diff/
Testing
-------
This passes federation 'make test' testing.
Thanks,
Chug Rolke
Re: Review Request: C++ Broker should not declare existing federated queues
during bridge creation
Posted by Alan Conway <ac...@redhat.com>.
> On Nov. 6, 2012, 9:28 p.m., Alan Conway wrote:
> > Look sensible, but what is the problem that prompted this patch?
> >
Ship it.
- Alan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7901/#review13172
-----------------------------------------------------------
On Nov. 6, 2012, 7:20 p.m., Chug Rolke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7901/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2012, 7:20 p.m.)
>
>
> Review request for qpid and Alan Conway.
>
>
> Description
> -------
>
> This patch conditionalizes the queue declaration during bridge creation. The queue is declared only if there is no existing queue, which is when the supplied queue name is blank.
>
>
> This addresses bug QPID-4423.
> https://issues.apache.org/jira/browse/QPID-4423
>
>
> Diffs
> -----
>
> trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1406267
>
> Diff: https://reviews.apache.org/r/7901/diff/
>
>
> Testing
> -------
>
> This passes federation 'make test' testing.
>
>
> Thanks,
>
> Chug Rolke
>
>
Re: Review Request: C++ Broker should not declare existing federated queues
during bridge creation
Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7901/#review13172
-----------------------------------------------------------
Look sensible, but what is the problem that prompted this patch?
- Alan Conway
On Nov. 6, 2012, 7:20 p.m., Chug Rolke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7901/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2012, 7:20 p.m.)
>
>
> Review request for qpid and Alan Conway.
>
>
> Description
> -------
>
> This patch conditionalizes the queue declaration during bridge creation. The queue is declared only if there is no existing queue, which is when the supplied queue name is blank.
>
>
> This addresses bug QPID-4423.
> https://issues.apache.org/jira/browse/QPID-4423
>
>
> Diffs
> -----
>
> trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1406267
>
> Diff: https://reviews.apache.org/r/7901/diff/
>
>
> Testing
> -------
>
> This passes federation 'make test' testing.
>
>
> Thanks,
>
> Chug Rolke
>
>