You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by markerickson-wf <gi...@git.apache.org> on 2016/11/19 04:20:40 UTC
[GitHub] thrift pull request #1135: THRIFT-3981 Enable analyzer strong mode in Dart l...
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/1135
THRIFT-3981 Enable analyzer strong mode in Dart library
@ericklaus-wf
@brianshannan-wf
@stevenosborne-wf
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markerickson-wf/thrift dart-strong-mode
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1135
----
commit cf1239fcf749f73b36d2dbdcca4a22a52484cb21
Author: Mark Erickson <ma...@workiva.com>
Date: 2016-11-19T04:18:19Z
THRIFT-3981 Enable analyzer strong mode in Dart library
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1135: THRIFT-3981 Enable analyzer strong mode in Dart library
Posted by brianshannan-wf <gi...@git.apache.org>.
Github user brianshannan-wf commented on the issue:
https://github.com/apache/thrift/pull/1135
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1135: THRIFT-3981 Enable analyzer strong mode in Dart l...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1135: THRIFT-3981 Enable analyzer strong mode in Dart library
Posted by ericklaus-wf <gi...@git.apache.org>.
Github user ericklaus-wf commented on the issue:
https://github.com/apache/thrift/pull/1135
+1
Looks like the failed travis-ci test is not related to Dart?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1135: THRIFT-3981 Enable analyzer strong mode in Dart library
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1135
I just tested with latest stable dart and it seems to work, so +1 from me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---