[GitHub] [hive] viirya commented on a change in pull request #1356: HIVE-23980: Shade Guava from hive-exec in Hive 2.3

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #1356:
URL: https://github.com/apache/hive/pull/1356#discussion_r465395633



##########
File path: common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java
##########
@@ -207,11 +207,11 @@ public Long getDuration(String method) {
   }
 
 
-  public ImmutableMap<String, Long> getStartTimes() {
+  public Map<String, Long> getStartTimes() {

Review comment:
       Without this change, a runtime error like the following was happened:
   
   ```
   java.lang.NoSuchMethodError: org.apache.hadoop.hive.ql.log.PerfLogger.getStartTimes()Lorg/apache/hive/com/google/common/collect/ImmutableMap;    
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org