You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2019/06/18 08:14:50 UTC
[kudu-CR] DeltaPreparer: use vectors instead of deques
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13668
Change subject: DeltaPreparer: use vectors instead of deques
......................................................................
DeltaPreparer: use vectors instead of deques
We had a few std::deque<>s in this class that seem like they could just
as well use vectors. Vectors are a simpler data structure, so may as
well use it instead.
Change-Id: I4161d1dfbf91294f36487da077baaa5a61dd014e
---
M src/kudu/tablet/delta_store.h
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/13668/1
--
To view, visit http://gerrit.cloudera.org:8080/13668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4161d1dfbf91294f36487da077baaa5a61dd014e
Gerrit-Change-Number: 13668
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
[kudu-CR] DeltaPreparer: use vectors instead of deques
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13668 )
Change subject: DeltaPreparer: use vectors instead of deques
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4161d1dfbf91294f36487da077baaa5a61dd014e
Gerrit-Change-Number: 13668
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 19 Jun 2019 00:17:05 +0000
Gerrit-HasComments: No
[kudu-CR] DeltaPreparer: use vectors instead of deques
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13668 )
Change subject: DeltaPreparer: use vectors instead of deques
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/13668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4161d1dfbf91294f36487da077baaa5a61dd014e
Gerrit-Change-Number: 13668
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 Jun 2019 21:12:56 +0000
Gerrit-HasComments: No
[kudu-CR] DeltaPreparer: use vectors instead of deques
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13668 )
Change subject: DeltaPreparer: use vectors instead of deques
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4161d1dfbf91294f36487da077baaa5a61dd014e
Gerrit-Change-Number: 13668
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 Jun 2019 08:19:16 +0000
Gerrit-HasComments: No
[kudu-CR] DeltaPreparer: use vectors instead of deques
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13668 )
Change subject: DeltaPreparer: use vectors instead of deques
......................................................................
DeltaPreparer: use vectors instead of deques
We had a few std::deque<>s in this class that seem like they could just
as well use vectors. Vectors are a simpler data structure, so may as
well use it instead.
Change-Id: I4161d1dfbf91294f36487da077baaa5a61dd014e
Reviewed-on: http://gerrit.cloudera.org:8080/13668
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tablet/delta_store.h
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4161d1dfbf91294f36487da077baaa5a61dd014e
Gerrit-Change-Number: 13668
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] DeltaPreparer: use vectors instead of deques
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13668 )
Change subject: DeltaPreparer: use vectors instead of deques
......................................................................
Patch Set 1: Code-Review+1
Looks like there are some IWYU changes needed. I also re-kicked the Jenkins job to make sure the failures were flaky.
--
To view, visit http://gerrit.cloudera.org:8080/13668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4161d1dfbf91294f36487da077baaa5a61dd014e
Gerrit-Change-Number: 13668
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 Jun 2019 12:39:21 +0000
Gerrit-HasComments: No