You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/03/12 21:30:36 UTC
Review Request 19153: Sometimes cluster installation pauses for few minutes
between tasks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19153/
-----------------------------------------------------------
Review request for Ambari, Dmytro Sen and Sumit Mohanty.
Bugs: AMBARI-4992
https://issues.apache.org/jira/browse/AMBARI-4992
Repository: ambari
Description
-------
I prefer the approach of checking if the command queue is empty and then picking status commands from last_status. It is better as it can be done every 10 seconds whereas status commands are send by the server only every minute. I assume we still do not store duplicate commands in last_status.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/ActionQueue.py 731ac54
ambari-agent/src/main/python/ambari_agent/Controller.py 26985ef
ambari-agent/src/test/python/ambari_agent/TestController.py 1e110da
Diff: https://reviews.apache.org/r/19153/diff/
Testing
-------
Manual cluster installation and running unit tests
----------------------------------------------------------------------
Ran 282 tests in 12.539s
OK
Process finished with exit code 0
Thanks,
Dmitro Lisnichenko
Re: Review Request 19153: Sometimes cluster installation pauses for few
minutes between tasks
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19153/
-----------------------------------------------------------
(Updated March 13, 2014, 1:58 p.m.)
Review request for Ambari, Dmytro Sen and Sumit Mohanty.
Changes
-------
fixed
Bugs: AMBARI-4992
https://issues.apache.org/jira/browse/AMBARI-4992
Repository: ambari
Description
-------
I prefer the approach of checking if the command queue is empty and then picking status commands from last_status. It is better as it can be done every 10 seconds whereas status commands are send by the server only every minute. I assume we still do not store duplicate commands in last_status.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/ActionQueue.py 731ac54
ambari-agent/src/main/python/ambari_agent/Controller.py 26985ef
ambari-agent/src/test/python/ambari_agent/TestController.py 1e110da
Diff: https://reviews.apache.org/r/19153/diff/
Testing
-------
Manual cluster installation and running unit tests
----------------------------------------------------------------------
Ran 282 tests in 12.539s
OK
Process finished with exit code 0
Thanks,
Dmitro Lisnichenko
Re: Review Request 19153: Sometimes cluster installation pauses for few
minutes between tasks
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19153/#review37052
-----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/Controller.py
<https://reviews.apache.org/r/19153/#comment68304>
4 spaces spaces
- Dmytro Sen
On March 12, 2014, 8:30 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19153/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 8:30 p.m.)
>
>
> Review request for Ambari, Dmytro Sen and Sumit Mohanty.
>
>
> Bugs: AMBARI-4992
> https://issues.apache.org/jira/browse/AMBARI-4992
>
>
> Repository: ambari
>
>
> Description
> -------
>
> I prefer the approach of checking if the command queue is empty and then picking status commands from last_status. It is better as it can be done every 10 seconds whereas status commands are send by the server only every minute. I assume we still do not store duplicate commands in last_status.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 731ac54
> ambari-agent/src/main/python/ambari_agent/Controller.py 26985ef
> ambari-agent/src/test/python/ambari_agent/TestController.py 1e110da
>
> Diff: https://reviews.apache.org/r/19153/diff/
>
>
> Testing
> -------
>
> Manual cluster installation and running unit tests
>
>
> ----------------------------------------------------------------------
> Ran 282 tests in 12.539s
>
> OK
>
> Process finished with exit code 0
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 19153: Sometimes cluster installation pauses for few
minutes between tasks
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19153/#review37053
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On March 12, 2014, 8:30 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19153/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 8:30 p.m.)
>
>
> Review request for Ambari, Dmytro Sen and Sumit Mohanty.
>
>
> Bugs: AMBARI-4992
> https://issues.apache.org/jira/browse/AMBARI-4992
>
>
> Repository: ambari
>
>
> Description
> -------
>
> I prefer the approach of checking if the command queue is empty and then picking status commands from last_status. It is better as it can be done every 10 seconds whereas status commands are send by the server only every minute. I assume we still do not store duplicate commands in last_status.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 731ac54
> ambari-agent/src/main/python/ambari_agent/Controller.py 26985ef
> ambari-agent/src/test/python/ambari_agent/TestController.py 1e110da
>
> Diff: https://reviews.apache.org/r/19153/diff/
>
>
> Testing
> -------
>
> Manual cluster installation and running unit tests
>
>
> ----------------------------------------------------------------------
> Ran 282 tests in 12.539s
>
> OK
>
> Process finished with exit code 0
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>