[GitHub] [superset] suddjian commented on a change in pull request #15186: fix(dashboard-list): change name of dashboard is not reflected instantly

[GitBox <gi...@apache.org>]

suddjian commented on a change in pull request #15186:
URL: https://github.com/apache/superset/pull/15186#discussion_r666450966



##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
##########
@@ -157,7 +157,7 @@ function DashboardList(props: DashboardListProps) {
       ({ json = {} }) => {
         setDashboards(
           dashboards.map(dashboard => {
-            if (dashboard.id === json.id) {
+            if (dashboard.id === json?.result.id) {

Review comment:
       I think changing the order of the list will be surprising for the user. It may look like the dashboard they were editing has disappeared.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org