You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/28 19:48:09 UTC
[GitHub] dongjoon-hyun commented on a change in pull request #23384:
[SPARK-26443 ][CORE] Use ConfigEntry for hardcoded configs for history
category.
dongjoon-hyun commented on a change in pull request #23384: [SPARK-26443 ][CORE] Use ConfigEntry for hardcoded configs for history category.
URL: https://github.com/apache/spark/pull/23384#discussion_r244394512
##########
File path: core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
##########
@@ -79,7 +79,7 @@ private[history] class HistoryServerArguments(conf: SparkConf, args: Array[Strin
|
| spark.history.fs.logDirectory Directory where app logs are stored
| (default: file:/tmp/spark-events)
- | spark.history.fs.updateInterval How often to reload log data from storage
Review comment:
Ur, it is good to remove the deprecated one as many as possible in Spark 3.0. When I searched this string during reviews, there were only two instances; here and deprecation checking test case. @mgaido91 , what do you mean by `quite used`? We already accepted this deprecated one and new one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org