You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Zhijiang (Jira)" <ji...@apache.org> on 2020/03/25 07:57:00 UTC
[jira] [Commented] (FLINK-16753) Exception from
AsyncCheckpointRunnable should be wrapped in CheckpointException
[ https://issues.apache.org/jira/browse/FLINK-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066463#comment-17066463 ]
Zhijiang commented on FLINK-16753:
----------------------------------
Hey [~wind_ljy], could you point out where `owner.getEnvironment().declineCheckpoint` is called in specific class? Then we can better understand the context.
> Exception from AsyncCheckpointRunnable should be wrapped in CheckpointException
> -------------------------------------------------------------------------------
>
> Key: FLINK-16753
> URL: https://issues.apache.org/jira/browse/FLINK-16753
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Checkpointing
> Affects Versions: 1.10.0
> Reporter: Jiayi Liao
> Priority: Major
>
> If an exception is thrown when task is doing aysnc checkpoint, the checkpoint will be declined and regarded as {{CheckpointFailureReason.JOB_FAILURE}}, which gives a wrong message to users.
> I think we can simply replace
> {code:java}
> owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(), checkpointException);
> {code}
> with
>
> {code:java}
> owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(), new CheckpointException(CheckpointFailureReason.EXCEPTION, checkpointException));
> {code}
> cc [~trohrmann]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)