You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackkleeman (via GitHub)" <gi...@apache.org> on 2023/04/27 21:46:13 UTC
[GitHub] [arrow-datafusion] jackkleeman opened a new pull request, #6146: Support uint64 literals
jackkleeman opened a new pull request, #6146:
URL: https://github.com/apache/arrow-datafusion/pull/6146
It should be possible to compare numeric types to uint64 literals. Currently for anything above the int64 max, it will become a float or a decimal128 depending on config. The float conversion is lossy, and the decimal type is currently not comparable with uint64, so both of these are problematic.
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #6145.
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
Yes
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
Potentially this will affect how some queries are interpreted, where int literals greater than int64-max are provided.
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6146: Support uint64 literals
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6146:
URL: https://github.com/apache/arrow-datafusion/pull/6146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6146: Support uint64 literals
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6146:
URL: https://github.com/apache/arrow-datafusion/pull/6146#issuecomment-1529037587
Thanks again @jackkleeman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6146: Support uint64 literals
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6146:
URL: https://github.com/apache/arrow-datafusion/pull/6146#issuecomment-1527672268
THanks @jackkleeman and @yukkit -- I have kicked off the CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6146: Support uint64 literals
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6146:
URL: https://github.com/apache/arrow-datafusion/pull/6146#issuecomment-1528993504
I took the liberty of fixing the `cargo fmt` issue and merging up from main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yukkit commented on pull request #6146: Support uint64 literals
Posted by "yukkit (via GitHub)" <gi...@apache.org>.
yukkit commented on PR #6146:
URL: https://github.com/apache/arrow-datafusion/pull/6146#issuecomment-1526945493
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #6146: Support uint64 literals
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #6146:
URL: https://github.com/apache/arrow-datafusion/pull/6146#discussion_r1181112291
##########
datafusion/sql/src/expr/value.rs:
##########
@@ -56,6 +56,8 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
))
} else if let Ok(n) = n.parse::<i64>() {
Ok(lit(n))
+ } else if let Ok(n) = n.parse::<u64>() {
Review Comment:
@jackkleeman please run `cargo fmt --all` and resubmit the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackkleeman commented on pull request #6146: Support uint64 literals
Posted by "jackkleeman (via GitHub)" <gi...@apache.org>.
jackkleeman commented on PR #6146:
URL: https://github.com/apache/arrow-datafusion/pull/6146#issuecomment-1531060601
thanks folks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org