You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/23 09:32:29 UTC

[GitHub] [shardingsphere] tianhao960 opened a new pull request, #20463: add alter and drop procedure statement for oracle

tianhao960 opened a new pull request, #20463:
URL: https://github.com/apache/shardingsphere/pull/20463

   Fixes #17635.
   
   Changes proposed in this pull request:
   - add alter and drop procedure statement for oracle 
   -
   -
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu merged pull request #20463: add alter and drop procedure statement for oracle

Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #20463:
URL: https://github.com/apache/shardingsphere/pull/20463


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #20463: add alter and drop procedure statement for oracle

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20463:
URL: https://github.com/apache/shardingsphere/pull/20463#issuecomment-1224566086

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20463?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#20463](https://codecov.io/gh/apache/shardingsphere/pull/20463?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (12f6385) into [master](https://codecov.io/gh/apache/shardingsphere/commit/388b32ea6a4a9cbb64655ae51c04913764f88ad5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (388b32e) will **increase** coverage by `0.08%`.
   > The diff coverage is `37.64%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #20463      +/-   ##
   ============================================
   + Coverage     60.55%   60.63%   +0.08%     
   - Complexity     2432     2440       +8     
   ============================================
     Files          3927     3936       +9     
     Lines         55182    55195      +13     
     Branches       9356     9352       -4     
   ============================================
   + Hits          33416    33470      +54     
   + Misses        18922    18876      -46     
   - Partials       2844     2849       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../dbdiscovery/route/DatabaseDiscoverySQLRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/20463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYmRpc2NvdmVyeS9yb3V0ZS9EYXRhYmFzZURpc2NvdmVyeVNRTFJvdXRlci5qYXZh) | `95.23% <ø> (ø)` | |
   | [...nce/FixedPrimaryReadQueryLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/20463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvRml4ZWRQcmltYXJ5UmVhZFF1ZXJ5TG9hZEJhbGFuY2VBbGdvcml0aG0uamF2YQ==) | `60.00% <ø> (ø)` | |
   | [...xedReplicaRandomReadQueryLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/20463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvRml4ZWRSZXBsaWNhUmFuZG9tUmVhZFF1ZXJ5TG9hZEJhbGFuY2VBbGdvcml0aG0uamF2YQ==) | `80.00% <ø> (ø)` | |
   | [...eplicaRoundRobinReadQueryLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/20463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvRml4ZWRSZXBsaWNhUm91bmRSb2JpblJlYWRRdWVyeUxvYWRCYWxhbmNlQWxnb3JpdGhtLmphdmE=) | `80.00% <ø> (ø)` | |
   | [...xedReplicaWeightReadQueryLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/20463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvRml4ZWRSZXBsaWNhV2VpZ2h0UmVhZFF1ZXJ5TG9hZEJhbGFuY2VBbGdvcml0aG0uamF2YQ==) | `71.69% <ø> (ø)` | |
   | [...adbalance/RandomReadQueryLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/20463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvUmFuZG9tUmVhZFF1ZXJ5TG9hZEJhbGFuY2VBbGdvcml0aG0uamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...lance/RoundRobinReadQueryLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/20463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvUm91bmRSb2JpblJlYWRRdWVyeUxvYWRCYWxhbmNlQWxnb3JpdGhtLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...ransactionRandomReadQueryLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/20463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvVHJhbnNhY3Rpb25SYW5kb21SZWFkUXVlcnlMb2FkQmFsYW5jZUFsZ29yaXRobS5qYXZh) | `66.66% <ø> (ø)` | |
   | [...actionRoundRobinReadQueryLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/20463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvVHJhbnNhY3Rpb25Sb3VuZFJvYmluUmVhZFF1ZXJ5TG9hZEJhbGFuY2VBbGdvcml0aG0uamF2YQ==) | `66.66% <ø> (ø)` | |
   | [...ransactionWeightReadQueryLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/20463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvVHJhbnNhY3Rpb25XZWlnaHRSZWFkUXVlcnlMb2FkQmFsYW5jZUFsZ29yaXRobS5qYXZh) | `69.38% <ø> (ø)` | |
   | ... and [87 more](https://codecov.io/gh/apache/shardingsphere/pull/20463/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] tianhao960 commented on a diff in pull request #20463: add alter and drop procedure statement for oracle

Posted by GitBox <gi...@apache.org>.
tianhao960 commented on code in PR #20463:
URL: https://github.com/apache/shardingsphere/pull/20463#discussion_r952852024


##########
shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/dialect/statement/oracle/ddl/OracleAlterProcedureStatement.java:
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl;
+
+import lombok.ToString;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.AlterProcedureStatement;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.OracleStatement;
+
+@ToString(callSuper = true)
+public class OracleAlterProcedureStatement extends AlterProcedureStatement implements OracleStatement {

Review Comment:
   have modify according to the comments



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #20463: add alter and drop procedure statement for oracle

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #20463:
URL: https://github.com/apache/shardingsphere/pull/20463#discussion_r952515919


##########
shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/dialect/statement/oracle/ddl/OracleAlterProcedureStatement.java:
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl;
+
+import lombok.ToString;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.AlterProcedureStatement;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.OracleStatement;
+
+@ToString(callSuper = true)
+public class OracleAlterProcedureStatement extends AlterProcedureStatement implements OracleStatement {

Review Comment:
   Please add javadoc and final for OracleAlterProcedureStatement.



##########
shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/StoreProcedure.g4:
##########
@@ -23,6 +23,22 @@ call
     : CALL 
     ;
 
+alterProcedure
+    : ALTER PROCEDURE (schemaName DOT_)? procedureName ( procedureCompileClause | ( EDITIONABLE | NONEDITIONABLE ) )

Review Comment:
   Please remove unnecessary spaces before and after the parentheses.



##########
shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/dialect/statement/oracle/ddl/OracleDropProcedureStatement.java:
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl;
+
+import lombok.ToString;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.DropProcedureStatement;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.OracleStatement;
+
+@ToString(callSuper = true)
+public class OracleDropProcedureStatement extends DropProcedureStatement implements OracleStatement {

Review Comment:
   Please add javadoc and final for OracleDropProcedureStatement.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org