You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mistercrunch (via GitHub)" <gi...@apache.org> on 2025/07/09 00:17:02 UTC

[PR] fix: improve login page placement and width [superset]

mistercrunch opened a new pull request, #34108:
URL: https://github.com/apache/superset/pull/34108

   Some small adjustments to make the login page look more standard.
   
   - Width set to 400px, should be plenty
   - centering the card vertically
   - making sure things look decent on mobile using max-width
   
   <img width="503" alt="Screenshot 2025-07-08 at 5 13 43 PM" src="https://github.com/user-attachments/assets/10f2059e-7225-4d98-b79d-51a4dab38292" />
   <img width="497" alt="Screenshot 2025-07-08 at 5 13 31 PM" src="https://github.com/user-attachments/assets/c1018c3a-92d6-434f-b944-fa516792160d" />
   <img width="1728" alt="Screenshot 2025-07-08 at 5 13 20 PM" src="https://github.com/user-attachments/assets/28947651-20b0-458d-a987-1e4260846adb" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: improve login page placement and width [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #34108:
URL: https://github.com/apache/superset/pull/34108#discussion_r2195569692


##########
superset-frontend/src/pages/Login/index.tsx:
##########
@@ -57,8 +57,10 @@ enum AuthType {
 
 const StyledCard = styled(Card)`
   ${({ theme }) => css`
-    width: 40%;
+    max-width: 400px;

Review Comment:
   Actually, another idea would be to move it to the base/root component... rather than styling it here. Or adding a prop for a particular width.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: improve login page placement and width [superset]

Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #34108:
URL: https://github.com/apache/superset/pull/34108#discussion_r2193659577


##########
superset-frontend/src/pages/Login/index.tsx:
##########
@@ -57,8 +57,10 @@ enum AuthType {
 
 const StyledCard = styled(Card)`
   ${({ theme }) => css`
-    width: 40%;
+    max-width: 400px;
+    width: 100%;
     margin-top: ${theme.marginXL}px;
+    color: ${theme.colorBgContainer};

Review Comment:
   ### Incorrect Theme Token Usage <sub>![category Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Using theme.colorBgContainer for text color is incorrect as this token is meant for background colors.
   
   
   ###### Why this matters
   This will likely result in poor text visibility or contrast issues as background color tokens are being used for text content.
   
   ###### Suggested change ∙ *Feature Preview*
   Use the appropriate text color token `theme.colorText` instead:
   ```typescript
   color: ${theme.colorText};
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/68f5520a-a748-4748-a07b-ad2457208620/upvote) [![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/68f5520a-a748-4748-a07b-ad2457208620?what_not_true=true)  [![Not in Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/68f5520a-a748-4748-a07b-ad2457208620?what_out_of_scope=true) [![Not in coding standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/68f5520a-a748-4748-a07b-ad2457208620?what_not_in_standard=true) [![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/68f5520a-a748-4748-a07b-ad2457208620)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:79869a6e-f78a-4bc8-8930-ca6b9bc4cd90 -->
   
   
   [](79869a6e-f78a-4bc8-8930-ca6b9bc4cd90)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: improve login page placement and width [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #34108:
URL: https://github.com/apache/superset/pull/34108#discussion_r2194392426


##########
superset-frontend/src/pages/Login/index.tsx:
##########
@@ -57,8 +57,10 @@ enum AuthType {
 
 const StyledCard = styled(Card)`
   ${({ theme }) => css`
-    width: 40%;
+    max-width: 400px;

Review Comment:
   I wonder if we need a few constants in the theme for this... maybe some reusable widths for modals/forms/columns.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix: improve login page placement and width [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch merged PR #34108:
URL: https://github.com/apache/superset/pull/34108


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org