You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Yonik Seeley (Commented) (JIRA)" <ji...@apache.org> on 2012/04/10 17:31:18 UTC
[jira] [Commented] (SOLR-3346) qt Dispatching Request Handler
[ https://issues.apache.org/jira/browse/SOLR-3346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250742#comment-13250742 ]
Yonik Seeley commented on SOLR-3346:
------------------------------------
I think I would prefer leaving things as they are (as you say, it's just a small piece of code in the SolrDispatchFilter... and "qt" is all about dispatching!)
It would seem to introduce extra overhead for anyone that wanted to use "qt" as they did before, and there's a good probability that it would introduce more bugs as well.
> qt Dispatching Request Handler
> ------------------------------
>
> Key: SOLR-3346
> URL: https://issues.apache.org/jira/browse/SOLR-3346
> Project: Solr
> Issue Type: New Feature
> Components: search
> Reporter: David Smiley
> Fix For: 4.0
>
>
> Instead of 'qt' being handled by the SolrDispatchFilter (a Servlet Filter), it would be better implemented as a request handler, with a suggested name of DispatchingRequestHandler. This is better because:
> * it keeps the servlet filter more focused / simplified (albeit just a little)
> * it simplifies solrconfig.xml by removing/deprecating handleSelect="true". 'qt' is less magic, it works more explicitly.
> * if you don't want to use 'qt' dispatch, simply don't use DispatchingRequestHandler
> * DispatchingRequestHandler would get used by EmbeddedSolrServer but SolrDispatchFilter is not.
> Credit: Hoss's idea, Erik coded a first draft
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org