You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by apurvam <gi...@git.apache.org> on 2017/06/02 05:43:07 UTC
[GitHub] kafka pull request #3204: KAFKA-5322: Add an `OPERATION_NOT_ATTEMPTED` error...
GitHub user apurvam opened a pull request:
https://github.com/apache/kafka/pull/3204
KAFKA-5322: Add an `OPERATION_NOT_ATTEMPTED` error code
In the `AddPartitionsToTxn` request handling, if even one partition fails authorization checks, the entire request is essentially failed. However, the `AddPartitionsToTxnResponse` today will only contain the error codes for the topics which failed authorization. It will have no error code for the topics which succeeded, making it inconsistent with other APIs.
This patch adds a new error code `OPERATION_NOT_ATTEMPTED` which is returned for the successful partitions to indicate that they were not added to the transaction.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apurvam/kafka KAFKA-5322-add-operation-not-attempted-for-add-partitions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3204.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3204
----
commit f454d495df20764105a42fe5e66351683e1a23ac
Author: Apurva Mehta <ap...@confluent.io>
Date: 2017-06-02T04:27:30Z
WIP
commit 764d8dc713ffde5703d58eb2a485567c6552f557
Author: Apurva Mehta <ap...@confluent.io>
Date: 2017-06-02T04:58:02Z
Update comments and client code
commit 7651210a7156a54376ff8a827b9220f60ff0ff20
Author: Apurva Mehta <ap...@confluent.io>
Date: 2017-06-02T05:38:49Z
Add test, fix checkstyle
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request #3204: KAFKA-5322: Add an `OPERATION_NOT_ATTEMPTED` error...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/3204
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---