You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/31 15:35:05 UTC
[GitHub] srowen commented on a change in pull request #23400: [SPARK-26499]
[SQL] JdbcUtils.makeGetter does not handle ByteType
srowen commented on a change in pull request #23400: [SPARK-26499] [SQL] JdbcUtils.makeGetter does not handle ByteType
URL: https://github.com/apache/spark/pull/23400#discussion_r244594945
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -456,6 +456,10 @@ object JdbcUtils extends Logging {
(rs: ResultSet, row: InternalRow, pos: Int) =>
row.update(pos, rs.getBytes(pos + 1))
+ case ByteType =>
Review comment:
This should be after `ShortType`, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org