You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Emily Yeh <ey...@pivotal.io> on 2017/06/02 16:06:38 UTC
Re: Review Request 59686: GEODE-2983: correctly handling --J option
value that has ", " inside.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59686/#review176783
-----------------------------------------------------------
Ship it!
Ship It!
- Emily Yeh
On May 31, 2017, 10:44 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59686/
> -----------------------------------------------------------
>
> (Updated May 31, 2017, 10:44 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2983: correctly handling --J option value that has "," inside.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java 288ea054ae1230c480d141c0159d6ccf9c299a7d
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 74acfd6e03613ac4d0c62fcdd4ea859d1c74d2f2
> geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserParsingTest.java 4467792f60a2a3bf7cc53cf35e997e7462882539
>
>
> Diff: https://reviews.apache.org/r/59686/diff/2/
>
>
> Testing
> -------
>
> precheckin running
>
>
> Thanks,
>
> Jinmei Liao
>
>