[jira] [Updated] (OAK-5892) ResultRowToAuthorizable: create user/group from tree

["angela (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela updated OAK-5892:
------------------------
    Attachment: ListIdentitiesTest-fixRowToAuthorizable-withoutCurrent.txt
                ListIdentitiesTest-fixRowToAuthorizable-statusquo.txt
                ListIdentitiesTest-fixRowToAuthorizable-withCurrent.txt

Results of {{ListIdentitiesTest}} benchmark with the proposed change included. To see effect of the modification please see OAK-4920 for results for the same queries without the changes.

The benchmarks were executed with the different options outlined in OAK-4920 to further spot any traversal warnings.

h6. "status quo"
original query as present before fixing OAK-4920
{code}
userManager.findAuthorizables("jcr:primaryType", null);
{code}
=> traversal warning

h6. simple-extidquery-without-currentpath-element
{code}
userManager.findAuthorizables(DefaultSyncContext.REP_EXTERNAL_ID, null);
{code}
=> no traversal warning
=> this query ended up in the fix for OAK-4920

h6. simple-extidquery-with-currentpath-element
{code}
userManager.findAuthorizables("./"+DefaultSyncContext.REP_EXTERNAL_ID, null);
{code}
=> gives traversal warning 


> ResultRowToAuthorizable: create user/group from tree
> ----------------------------------------------------
>
>                 Key: OAK-5892
>                 URL: https://issues.apache.org/jira/browse/OAK-5892
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: angela
>              Labels: perfomance
>         Attachments: ListIdentitiesTest-fixRowToAuthorizable-statusquo.txt, ListIdentitiesTest-fixRowToAuthorizable-withCurrent.txt, ListIdentitiesTest-fixRowToAuthorizable-withoutCurrent.txt
>
>
> while measuring performance of possible fixes for OAK-4920, i noticed a possible improvement within the ResultRowToAuthorizable used to within the user query code base: instead of retrieving authorizables by ID the code can be simplified by using the tree that has already been obtained.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)