You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Max Gekk (Jira)" <ji...@apache.org> on 2022/10/13 13:22:00 UTC
[jira] [Comment Edited] (SPARK-37935) Migrate onto error classes
[ https://issues.apache.org/jira/browse/SPARK-37935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617047#comment-17617047 ]
Max Gekk edited comment on SPARK-37935 at 10/13/22 1:21 PM:
------------------------------------------------------------
[~panbingkun] [~ivoson] [~xleesf] [~YActs] [~lvshaokang] [~kaifeiYi] [~LuciferYang] I have opened a few sub-tasks to improve the error framework. Please, feel free to take some of them if you are interested in this. also cc [~wenchen] [~itholic] For instance:
* Migrate type check failures on error classes. One of the tasks is https://issues.apache.org/jira/browse/SPARK-40369
* Use checkError() in test suites, see https://issues.apache.org/jira/browse/SPARK-40784
was (Author: maxgekk):
[~panbingkun] [~ivoson] [~xleesf] [~YActs] [~lvshaokang] [~kaifeiYi] I have opened a few sub-tasks to improve the error framework. Please, feel free to take some of them if you are interested in this. also cc [~wenchen] [~itholic] For instance:
* Migrate type check failures on error classes. One of the tasks is https://issues.apache.org/jira/browse/SPARK-40369
* Use checkError() in test suites, see https://issues.apache.org/jira/browse/SPARK-40784
> Migrate onto error classes
> --------------------------
>
> Key: SPARK-37935
> URL: https://issues.apache.org/jira/browse/SPARK-37935
> Project: Spark
> Issue Type: Umbrella
> Components: Spark Core, SQL
> Affects Versions: 3.3.0
> Reporter: Max Gekk
> Assignee: Max Gekk
> Priority: Major
> Fix For: 3.4.0
>
>
> The PR https://github.com/apache/spark/pull/32850 introduced error classes as a part of the error messages framework (https://issues.apache.org/jira/browse/SPARK-33539). Need to migrate all exceptions from QueryExecutionErrors, QueryCompilationErrors and QueryParsingErrors on the error classes using instances of SparkThrowable, and carefully test every error class by writing tests in dedicated test suites:
> * QueryExecutionErrorsSuite for the errors that are occurred during query execution
> * QueryCompilationErrorsSuite ... query compilation or eagerly executing commands
> * QueryParsingErrorsSuite ... parsing errors
> Here is an example https://github.com/apache/spark/pull/35157 of how an existing Java exception can be replaced, and testing of related error classes.At the end, we should migrate all exceptions from the files Query.*Errors.scala and cover all error classes from the error-classes.json file by tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org