You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/12 17:54:31 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4977: arch/sim: add CONFIG_SIM_STACKSIZE_ADJUSTMENT to reduce variability

xiaoxiang781216 commented on pull request #4977:
URL: https://github.com/apache/incubator-nuttx/pull/4977#issuecomment-1011305739


   > i'm not sure if this is a good idea because
   > 
   > * this breaks existing configurations
   
   Could you explain more?
   
   > * it makes stack-related api very confusing (eg. pthread_attr_setstack and pthread_attr_setstacksize)
   
   SIM_STACKSIZE_ADJUSTMENT is used only for sim, the stack on sim already has huge difference to other arch. This patch is try to fix the program hard code the stack size in code or config with a fixed default value.
   
   > * stacksize is inherently arch-dependent
   
   DEFAULT_TASK_STACKSIZE could cover the most arch difference.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org