You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/12/10 15:27:05 UTC
[GitHub] tillrohrmann commented on a change in pull request #7004:
[FLINK-10743] [runtime] Use 0 processExitCode for ApplicationStatus.CANCELED
tillrohrmann commented on a change in pull request #7004: [FLINK-10743] [runtime] Use 0 processExitCode for ApplicationStatus.CANCELED
URL: https://github.com/apache/flink/pull/7004#discussion_r240254518
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/ApplicationStatus.java
##########
@@ -32,7 +32,7 @@
FAILED(1443),
Review comment:
Technically speaking, I think that all `ApplicationStatus` which don't indicate a failure of the Flink system should return `0`. `FAILED` for example is currently used if the job terminally failed but it does not mean that the Flink cluster itself has failed. I would only return a non-zero return value if Flink itself has failed (e.g. due to an initialization error). But this is probably part of a follow up issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services