[GitHub] [spark] cloud-fan commented on a diff in pull request #40623: [SPARK-43009][SQL] Parameterized `sql()` with `Any` constants

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #40623:
URL: https://github.com/apache/spark/pull/40623#discussion_r1155712439


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -215,15 +216,16 @@ class SparkSession private[sql] (
    * @param sqlText
    *   A SQL statement with named parameters to execute.
    * @param args
-   *   A map of parameter names to string values that are parsed as SQL literal expressions. For
-   *   example, map keys: "rank", "name", "birthdate"; map values: "1", "'Steven'",
-   *   "DATE'2023-03-21'". The fragments of string values belonged to SQL comments are skipped
-   *   while parsing.
+   *   A map of parameter names to Java/Scala objects that can be converted to SQL literal
+   *   expressions. See <a href="https://spark.apache.org/docs/latest/sql-ref-datatypes.html">

Review Comment:
   looking at the doc, I think we should update it to include the new java datetime api like `LocalDateTime`, and put then at the beginning to promote them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org