[GitHub] [spark] MaxGekk commented on a change in pull request #26094: [SPARK-29442][SQL] Set `default` mode should override the existing mode

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #26094: [SPARK-29442][SQL] Set `default` mode should override the existing mode
URL: https://github.com/apache/spark/pull/26094#discussion_r334103341
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
 ##########
 @@ -87,8 +87,7 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) {
       case "overwrite" => mode(SaveMode.Overwrite)
       case "append" => mode(SaveMode.Append)
       case "ignore" => mode(SaveMode.Ignore)
-      case "error" | "errorifexists" => mode(SaveMode.ErrorIfExists)
-      case "default" => this
+      case "error" | "errorifexists" | "default" => mode(SaveMode.ErrorIfExists)
 
 Review comment:
   I think the `"default"` mode should be mentioned in the list: https://github.com/apache/spark/pull/26094/files#diff-94fbd986b04087223f53697d4b6cab24R77-R81

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org