[GitHub] [accumulo] jzgithub1 commented on issue #1066: Speed up containKey calls by not always recomputing hashcodes

[GitBox <gi...@apache.org>]

jzgithub1 commented on issue #1066: Speed up containKey calls by not always recomputing hashcodes
URL: https://github.com/apache/accumulo/pull/1066#issuecomment-478650468
 
 
   Thanks for taking your time to show me that example Keith. I have not found that use case in my search of the Accumulo code but the possibility of someone doing that can't be ignored.  If I revert the modifications I made on the ArrayByteSequence, ByteSequence,  and MutableByteSequence then will the modifications to the Key class be helpful.  I can see in the RFileClientTest that recomputing of hashcodes will be prevented with the changes I made to the Key class.  MemKey extends from Key so the speed gain in key search can be gained in MemKey lookups.  This is a small issue and I know we are trying to get a release out, so I don't want to take up too much of anybody's cycles on this.   I have sped up some comparison code in the past doing something like this so I am just trying to do the same thing here. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services