You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@madlib.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/01 18:30:00 UTC
[jira] [Commented] (MADLIB-1109) Do not fail certain modules when
optimizer_control GUC is set to off in Greenplum
[ https://issues.apache.org/jira/browse/MADLIB-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109467#comment-16109467 ]
ASF GitHub Bot commented on MADLIB-1109:
----------------------------------------
GitHub user iyerr3 opened a pull request:
https://github.com/apache/incubator-madlib/pull/157
Multiple: Check optimizer_control before updating optimizer
JIRA: MADLIB-1109
This is applicable only for the Greenplum and HAWQ platforms:
We disable/enable ORCA using the 'optimizer' GUC in some functions for
performance reasons. GPDB/HAWQ has another GUC 'optimizer_control' which
allows the user to disable updates to the 'optimizer' GUC. Updating
'optimizer' when 'optimizer_control = off' leads to an ugly error.
This commit adds a check for the value of 'optimizer_control' and
updates 'optimizer' only if 'optimizer_control = on'.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iyerr3/incubator-madlib bugfix/optimizer_control
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-madlib/pull/157.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #157
----
commit b86eab834e0f56f5fcb501bf1ef50556000afe8b
Author: Rahul Iyer <ri...@apache.org>
Date: 2017-08-01T18:01:05Z
Multiple: Check optimizer_control before updating optimizer
JIRA: MADLIB-1109
This is applicable only for the Greenplum and HAWQ platforms:
We disable/enable ORCA using the 'optimizer' GUC in some functions for
performance reasons. GPDB/HAWQ has another GUC 'optimizer_control' which
allows the user to disable updates to the 'optimizer' GUC. Updating
'optimizer' when 'optimizer_control = off' leads to an ugly error.
This commit adds a check for the value of 'optimizer_control' and
updates 'optimizer' only if 'optimizer_control = on'.
----
> Do not fail certain modules when optimizer_control GUC is set to off in Greenplum
> ---------------------------------------------------------------------------------
>
> Key: MADLIB-1109
> URL: https://issues.apache.org/jira/browse/MADLIB-1109
> Project: Apache MADlib
> Issue Type: Task
> Components: All Modules
> Reporter: Frank McQuillan
> Priority: Minor
> Fix For: v1.12
>
>
> If the optimizer_control GUC is set to off in Greenplum, the following install checks will fail, and these MADlib functions will not work:
> * decision tree
> * random forest
> * LDA
> * k-Means
> * PMML export for decision tree
> * PMML export for random forest
> There may be others, but these are the ones I am aware of.
> The parameter optimizer_control
> https://gpdb.docs.pivotal.io/43130/ref_guide/config_params/guc-list.html#optimizer_control
> controls whether the server configuration parameter optimizer
> https://gpdb.docs.pivotal.io/43130/ref_guide/config_params/guc-list.html#optimizer
> can be changed. The parameter optimizer controls whether the GPORCA optimizer is enabled when running SQL queries.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)