[jira] [Commented] (NIFI-5792) NiFi should keep the created versioned flow information in case snapshot creation failure

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823266#comment-16823266 ] 

ASF subversion and git services commented on NIFI-5792:
-------------------------------------------------------

Commit c5d0643d1da2dbf5c2355a4ec8527073a99989f3 in nifi's branch refs/heads/master from Koji Kawamura
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c5d0643 ]

NIFI-5792: Remember created versioned flow information

- Before this fix, NiFi loses information about created versioned flow in case of subsequent snapshot creation failure, and NiFi API returned an error response
- This commit makes:
  - The created versioned Flow information is stored even if subsequent snapshot creation fails
  - NiFi API to return a successful 200 response in that case, but return versioned flow status as SYNC_FAILURE with an explanation. NiFi UI shows a popup error dialog with the explanation.
  - Versioned flow status will be LOCALLY_MODIFIED if the latest version is 0.

This closes #3134.

Signed-off-by: Mark Payne <ma...@hotmail.com>


> NiFi should keep the created versioned flow information in case snapshot creation failure
> -----------------------------------------------------------------------------------------
>
>                 Key: NIFI-5792
>                 URL: https://issues.apache.org/jira/browse/NIFI-5792
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: SDLC
>    Affects Versions: 1.5.0
>            Reporter: Koji Kawamura
>            Assignee: Koji Kawamura
>            Priority: Major
>              Labels: SDLC
>
> When a user attempts to start version control for a ProcessGroup, NiFi makes two NiFi Registry API requests, one for creating a new Flow, and the other is creating a new snapshot in the registry.
> If NiFi Registry returns error for the 2nd request for some reason (e.g. Git repository is used and its local repo is in a dirty state, having uncommitted files), NiFi loses the information about the created versioned Flow, that is returned by the 1st response.
> After that happens, if a user retries starting version control for the same ProcessGroup, NiFi sends the 1st request again, to create the Flow in NiFi Registry. Then NiFi Registry returns error response because a Flow with the same name already exists in the bucket.
> NiFi should remember the created versioned Flow information in case snapshot creation failure, so that the snapshot can be committed later when the NiFi Registry side issue gets addressed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)