svn commit: r1570105 - in /jackrabbit/oak/trunk/oak-auth-external/src: main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/ main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ test/java/org/apache/jackrab...

[an...@apache.org]

Author: angela
Date: Thu Feb 20 08:25:29 2014
New Revision: 1570105

URL: http://svn.apache.org/r1570105
Log:
javadoc, cleanup TODOs, minor improvement

Modified:
    jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/SyncException.java
    jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/DefaultSyncHandler.java
    jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java
    jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/TestIdentityProvider.java

Modified: jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/SyncException.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/SyncException.java?rev=1570105&r1=1570104&r2=1570105&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/SyncException.java (original)
+++ jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/SyncException.java Thu Feb 20 08:25:29 2014
@@ -17,19 +17,20 @@
 package org.apache.jackrabbit.oak.spi.security.authentication.external;
 
 /**
- * SyncException... TODO
+ * Exception thrown by methods defined on the {@code SyncHandler}
+ * interface indicating that user or group synchronization failed.
  */
 public class SyncException extends Exception {
 
-    public SyncException(String s) {
-        super(s);
+    public SyncException(String message) {
+        super(message);
     }
 
     public SyncException(Throwable throwable) {
         super(throwable);
     }
 
-    public SyncException(String s, Throwable throwable) {
-        super(s, throwable);
+    public SyncException(String message, Throwable throwable) {
+        super(message, throwable);
     }
 }
\ No newline at end of file

Modified: jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/DefaultSyncHandler.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/DefaultSyncHandler.java?rev=1570105&r1=1570104&r2=1570105&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/DefaultSyncHandler.java (original)
+++ jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/DefaultSyncHandler.java Thu Feb 20 08:25:29 2014
@@ -145,7 +145,7 @@ public class DefaultSyncHandler implemen
                     }
                     return true;
                 } else if (identity instanceof ExternalGroup) {
-                    // todo
+                    // TODO
                     return false;
 
                 } else {

Modified: jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java?rev=1570105&r1=1570104&r2=1570105&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java (original)
+++ jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java Thu Feb 20 08:25:29 2014
@@ -198,13 +198,11 @@ public class ExternalLoginModule extends
     }
 
     /**
-     * {@inheritDoc}
-     *
      * @return An immutable set containing only the {@link SimpleCredentials} class.
      */
     @Override
     protected Set<Class> getSupportedCredentials() {
-        // todo: maybe delegate getSupportedCredentials to IDP
+        // TODO: maybe delegate getSupportedCredentials to IDP
         Class scClass = SimpleCredentials.class;
         return Collections.singleton(scClass);
     }

Modified: jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/TestIdentityProvider.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/TestIdentityProvider.java?rev=1570105&r1=1570104&r2=1570105&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/TestIdentityProvider.java (original)
+++ jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/TestIdentityProvider.java Thu Feb 20 08:25:29 2014
@@ -26,9 +26,6 @@ import javax.jcr.Credentials;
 import javax.jcr.SimpleCredentials;
 import javax.security.auth.login.LoginException;
 
-/**
- * ExternalLoginModuleImpl... TODO
- */
 public class TestIdentityProvider implements ExternalIdentityProvider {
 
     private final Map<String, TestGroup> externalGroups = new HashMap<String, TestGroup>();