You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/09 07:51:41 UTC

[GitHub] [spark] Ngone51 commented on pull request #38995: [SPARK-41460][CORE] Introduce IsolatedThreadSafeRpcEndpoint to extend IsolatedRpcEndpoint

Ngone51 commented on PR #38995:
URL: https://github.com/apache/spark/pull/38995#issuecomment-1343967442

   > What about renaming IsolatedRpcEndpoint to IsolatedThreadSafeRpcEndpoint simply?
   
   I think this would breach the original design by the author argued at https://github.com/apache/spark/pull/26059#discussion_r336083143. I don't want to break it, though I also don't have a use case of `IsolatedButNotThreadSafeRpcEndpoint` in my mind.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org