You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/30 10:34:52 UTC
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #1971: [Improve]Use Jackson replace Fastjson
CalvinKirs commented on code in PR #1971:
URL: https://github.com/apache/incubator-seatunnel/pull/1971#discussion_r884682815
##########
seatunnel-connectors/seatunnel-connectors-spark/seatunnel-connector-spark-feishu/src/main/scala/org/apache/seatunnel/spark/feishu/FeishuClient.scala:
##########
@@ -16,25 +16,27 @@
*/
package org.apache.seatunnel.spark.feishu
-import scala.collection.mutable.ArrayBuffer
+import com.fasterxml.jackson.databind.JsonNode
+import com.fasterxml.jackson.databind.node.{ArrayNode, ObjectNode}
-import com.alibaba.fastjson.{JSON, JSONArray, JSONObject}
+import scala.collection.mutable.ArrayBuffer
import org.apache.http.{HttpEntity, HttpHeaders}
import org.apache.http.client.methods.{CloseableHttpResponse, RequestBuilder}
import org.apache.http.impl.client.{CloseableHttpClient, HttpClients}
import org.apache.http.util.EntityUtils
+import org.apache.seatunnel.common.utils.JsonUtils
import org.apache.spark.sql.Row
import org.apache.spark.sql.types.{DataTypes, StructField, StructType}
import org.slf4j.{Logger, LoggerFactory}
class FeishuClient(appId: String, appSecret: String) {
- val logger: Logger = LoggerFactory.getLogger(this.getClass)
+ /*val logger: Logger = LoggerFactory.getLogger(this.getClass)
def getToken: String = {
val url = Config.TOKEN_URL.format(appId, appSecret)
val result = this.requestFeishuApi(url, null)
logger.info(s"Request token and get result $result")
Review Comment:
I don't familiarize Scala, anyone could update this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org