You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/16 14:48:11 UTC

[GitHub] [shardingsphere] terrymanu opened a new issue #8179: Error message if circuit break mode has unnecessary test.

terrymanu opened a new issue #8179:
URL: https://github.com/apache/shardingsphere/issues/8179


   When execute sql in circuit break mode, it display:
   
   ```
   ERROR 10000 (C1000): 0Circuit break mode is ON.
   ```
   
   In word `0Circuit`, `0` is unnecessary, please remove it.
   
   ![image](https://user-images.githubusercontent.com/5516298/99266106-636ba280-285d-11eb-83a2-2ea19a1c4586.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu closed issue #8179: Error message if circuit break mode has unnecessary test.

Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #8179:
URL: https://github.com/apache/shardingsphere/issues/8179


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] dbhat6 commented on issue #8179: Error message if circuit break mode has unnecessary test.

Posted by GitBox <gi...@apache.org>.
dbhat6 commented on issue #8179:
URL: https://github.com/apache/shardingsphere/issues/8179#issuecomment-789087800


   @terrymanu I won't be able to take this up


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] totalo commented on issue #8179: Error message if circuit break mode has unnecessary test.

Posted by GitBox <gi...@apache.org>.
totalo commented on issue #8179:
URL: https://github.com/apache/shardingsphere/issues/8179#issuecomment-805866166


   > Hello i want to know how to open circuit break mode, @terrymanu @strongduanmu
   
   ohhh, I know, thx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] cenyu00 commented on issue #8179: Error message if circuit break mode has unnecessary test.

Posted by GitBox <gi...@apache.org>.
cenyu00 commented on issue #8179:
URL: https://github.com/apache/shardingsphere/issues/8179#issuecomment-728113939


   please assige me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tuohai666 commented on issue #8179: Error message if circuit break mode has unnecessary test.

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #8179:
URL: https://github.com/apache/shardingsphere/issues/8179#issuecomment-806365046


   LGTM. Please check one comment I left, then the PR can be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on issue #8179: Error message if circuit break mode has unnecessary test.

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #8179:
URL: https://github.com/apache/shardingsphere/issues/8179#issuecomment-806341914


   @totalo  Thank you, the change is excellent, I will do a little research and merge it soon


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] totalo commented on issue #8179: Error message if circuit break mode has unnecessary test.

Posted by GitBox <gi...@apache.org>.
totalo commented on issue #8179:
URL: https://github.com/apache/shardingsphere/issues/8179#issuecomment-804957312


   Hi , plz assige me,I want to have a try,thx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] totalo commented on issue #8179: Error message if circuit break mode has unnecessary test.

Posted by GitBox <gi...@apache.org>.
totalo commented on issue #8179:
URL: https://github.com/apache/shardingsphere/issues/8179#issuecomment-805725184


   Hello i want to know how to open circuit break mode, @terrymanu @strongduanmu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] dbhat6 commented on issue #8179: Error message if circuit break mode has unnecessary test.

Posted by GitBox <gi...@apache.org>.
dbhat6 commented on issue #8179:
URL: https://github.com/apache/shardingsphere/issues/8179#issuecomment-735260342


   @cenyu00 are you still working on this?
   Can I take it up if not?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] totalo commented on issue #8179: Error message if circuit break mode has unnecessary test.

Posted by GitBox <gi...@apache.org>.
totalo commented on issue #8179:
URL: https://github.com/apache/shardingsphere/issues/8179#issuecomment-806278882


   I found that the `sqlState` length defined by mysql error packet is `5`, but we defined it as` 6`. This will happen to all `errorMsgs`. I would like to modify our defined length to` 5`. Take a look. If this design is unreasonable, I will Try another method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu commented on issue #8179: Error message if circuit break mode has unnecessary test.

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #8179:
URL: https://github.com/apache/shardingsphere/issues/8179#issuecomment-787926609


   Hi @dbhat6 
   Please go ahead


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org