You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/03/17 03:52:53 UTC

[GitHub] [incubator-dolphinscheduler] oceanos opened a new issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data

oceanos opened a new issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2202
 
 
   
   **Describe**
   QueueName should not be stored in the table t_ds_user, which can result in inconsistent data.
   ![image](https://user-images.githubusercontent.com/11856424/76820155-4487bd00-6845-11ea-9f51-3d070be1313c.png)
   
   **Reproduce**
   1. Update queue's name
   2. Query Userlist 
   3. The queue's old name is returned
   
   **Expected**
   The new value should be returned
   
   **Version**
    -[dev]
   
   **Improvement
   - QueueId should be stored.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Eights-Li edited a comment on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data

Posted by GitBox <gi...@apache.org>.

Eights-Li edited a comment on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2202#issuecomment-600968550
 
 
   current t_ds_user table queue field sotre the queue_name not the queue_value.
   In FetchTaskThread, user.queue store queue_name, but tenant.queue store queue_value, so the user.queue should convert queue_value. 
   
   tip: when create queue in ds, create queue api - guarantee that queue and queue_name are unique. if you change the queue_name in t_ds_queue, the queue field will be change related to user

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Eights-Li commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data

Posted by GitBox <gi...@apache.org>.

Eights-Li commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2202#issuecomment-600968550
 
 
   current t_ds_user table queue field sotre the queue_name not the queue_value, i think store queue_value more suitable

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] liwenhe1993 edited a comment on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data

Posted by GitBox <gi...@apache.org>.

liwenhe1993 edited a comment on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2202#issuecomment-600668069
 
 
   @dailidong 
   > > +1
   > 
   > glad to hear that you will fix ,haha
   
   When I prepare to solve this bug, I find that the queue value of the `t_ds_user table` **has been updated**.
   
   ![1](https://user-images.githubusercontent.com/32166572/76973324-befe2d00-696a-11ea-8a9d-d55f94c8f2dd.png)
   
   ![2](https://user-images.githubusercontent.com/32166572/76973339-c1f91d80-696a-11ea-8efb-ab83ced0ab0b.png)
   
   ![3](https://user-images.githubusercontent.com/32166572/76973346-c4f40e00-696a-11ea-8277-b394868647b7.png)
   
   ![4](https://user-images.githubusercontent.com/32166572/76973351-c6bdd180-696a-11ea-9695-e6cf5c982812.png)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] liwenhe1993 commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data

Posted by GitBox <gi...@apache.org>.

liwenhe1993 commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2202#issuecomment-600668069
 
 
   > > +1
   > 
   > glad to hear that you will fix ,haha
   
   When I prepare to solve this bug, I find that the queue value of the `t_ds_user table` **has been updated**.
   
   ![1](https://user-images.githubusercontent.com/32166572/76973324-befe2d00-696a-11ea-8a9d-d55f94c8f2dd.png)
   
   ![2](https://user-images.githubusercontent.com/32166572/76973339-c1f91d80-696a-11ea-8efb-ab83ced0ab0b.png)
   
   ![3](https://user-images.githubusercontent.com/32166572/76973346-c4f40e00-696a-11ea-8277-b394868647b7.png)
   
   ![4](https://user-images.githubusercontent.com/32166572/76973351-c6bdd180-696a-11ea-9695-e6cf5c982812.png)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Eights-Li commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data

Posted by GitBox <gi...@apache.org>.

Eights-Li commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2202#issuecomment-601172126
 
 
   +1,  the queue_id replace queue field in t_ds_user, i will fix it 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Eights-Li commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data

Posted by GitBox <gi...@apache.org>.

Eights-Li commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2202#issuecomment-601496591
 
 
   The current implementation is okay but just not elegant enough, maybe should enhancement

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] oceanos commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data

Posted by GitBox <gi...@apache.org>.

oceanos commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2202#issuecomment-601158470
 
 
   ![image](https://user-images.githubusercontent.com/11856424/77068971-7f931780-6a22-11ea-98ff-6fe81355c0a7.png)
   ![image](https://user-images.githubusercontent.com/11856424/77069003-90dc2400-6a22-11ea-9fad-44980a68a686.png)
   The reference should be uniform, this problem was inelegantly resolved on the branch dev.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] Eights-Li removed a comment on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data

Posted by GitBox <gi...@apache.org>.

Eights-Li removed a comment on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2202#issuecomment-601172126
 
 
   +1,  the queue_id replace queue field in t_ds_user, i will fix it 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [dolphinscheduler] oceanos closed issue #2202: [enhancement] queueName should not be stored in the table t_ds_user, which can result in inconsistent data

Posted by GitBox <gi...@apache.org>.

oceanos closed issue #2202:
URL: https://github.com/apache/dolphinscheduler/issues/2202


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data

Posted by GitBox <gi...@apache.org>.

dailidong commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2202#issuecomment-600409645
 
 
   @xingchun-chen ,  please verify this problem

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data

Posted by GitBox <gi...@apache.org>.

xingchun-chen commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2202#issuecomment-600413729
 
 
   The queue value of the userManage page has been updated, but the queue value of the t_ds_user table has not been updated
    
   ![image](https://user-images.githubusercontent.com/55787491/76924127-6306ba80-6910-11ea-8742-88fe8813f6c7.png)
   ![image](https://user-images.githubusercontent.com/55787491/76924153-76198a80-6910-11ea-8591-b690bbab9580.png)
   
   Can anyone fix him！ 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] liwenhe1993 commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data

Posted by GitBox <gi...@apache.org>.

liwenhe1993 commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2202#issuecomment-600479421
 
 
   +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data

Posted by GitBox <gi...@apache.org>.

dailidong commented on issue #2202: [BUG] queueName should not be stored in the table t_ds_user, which can result in inconsistent data
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2202#issuecomment-600485244
 
 
   > +1
   
   glad to hear that you will fix ,haha

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] SunnyZ-L commented on issue #2202: [enhancement] queueName should not be stored in the table t_ds_user, which can result in inconsistent data

Posted by GitBox <gi...@apache.org>.

SunnyZ-L commented on issue #2202:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2202#issuecomment-820219487


   In my opinion that queue_name should not be stored in the T_DS_USER table. queue_id should be stored instead


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org